From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] optimize XFS_IS_REALTIME_INODE w/o realtime config
Date: Sun, 19 Aug 2007 20:08:47 +0100 [thread overview]
Message-ID: <20070819190847.GB2929@infradead.org> (raw)
In-Reply-To: <46C7627A.60503@sandeen.net>
On Sat, Aug 18, 2007 at 04:19:54PM -0500, Eric Sandeen wrote:
> Use XFS_IS_REALTIME_INODE in more places, and #define it to
> 0 if CONFIG_XFS_RT is off. This should be safe because mount
> checks in xfs_rtmount_init:
>
> # define xfs_rtmount_init(m) (((mp)->m_sb.sb_rblocks == 0)? 0 : (ENOSYS))
>
> so if we get mounted w/o CONFIG_XFS_RT, no realtime inodes should
> be encountered after that.
>
> Defining XFS_IS_REALTIME_INODE to 0 saves a bit of stack space,
> presumeably gcc can optimize around the various "if (0)" type
> checks:
Looks good to me.
Not sure if anyone disables the rt volume, but as long as it's a config
option we should try to avoid as much as possible away if it's not enabled.
next prev parent reply other threads:[~2007-08-19 19:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-18 21:19 [PATCH] optimize XFS_IS_REALTIME_INODE w/o realtime config Eric Sandeen
2007-08-19 19:08 ` Christoph Hellwig [this message]
2007-08-19 19:10 ` Eric Sandeen
2007-08-24 14:08 ` David Chinner
2007-08-24 17:53 ` [PATCH V2] " Eric Sandeen
2007-10-26 0:57 ` [PATCH V3] " Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070819190847.GB2929@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.