From: Tony Lindgren <tony@atomide.com>
To: Kevin Hilman <khilman@mvista.com>
Cc: linux-omap-open-source@linux.omap.com
Subject: Re: [PATCH] ARM: OMAP: MUSB: IRQ reset: babble handling is host only
Date: Mon, 20 Aug 2007 01:37:00 -0700 [thread overview]
Message-ID: <20070820083700.GE16454@atomide.com> (raw)
In-Reply-To: <20070817164724.560795636@mvista.com>
* Kevin Hilman <khilman@mvista.com> [070817 09:48]:
> In reset IRQ, move babble handling inside a host-ifdef since it
> doesn't apply (or compile) for gadget.
>
> Signed-off-by: Kevin Hilman <khilman@mvista.com>
> ---
> drivers/usb/musb/plat_uds.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> Index: dev/drivers/usb/musb/plat_uds.c
> ===================================================================
> --- dev.orig/drivers/usb/musb/plat_uds.c
> +++ dev/drivers/usb/musb/plat_uds.c
> @@ -604,6 +604,7 @@ static irqreturn_t musb_stage0_irq(struc
> * only host sees babble; only peripheral sees bus reset.
> */
> if (int_usb & MUSB_INTR_RESET) {
> +#ifdef CONFIG_USB_MUSB_HDRC_HCD
> if (devctl & MUSB_DEVCTL_HM) {
> /*
> * Looks like non-HS BABBLE can be ignored, but
> @@ -618,7 +619,9 @@ static irqreturn_t musb_stage0_irq(struc
> ERR("Stopping host session because of babble\n");
> musb_writeb(mbase, MUSB_DEVCTL, 0);
> }
> - } else {
> + } else
> +#endif /* CONFIG_USB_MUSB_HDRC_HCD */
> + {
> DBG(1, "BUS RESET\n");
>
> musb_g_reset(musb);
Thanks, pushing today.
Tony
prev parent reply other threads:[~2007-08-20 8:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 16:47 [PATCH] ARM: OMAP: MUSB: IRQ reset: babble handling is host only Kevin Hilman
2007-08-20 8:37 ` Tony Lindgren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070820083700.GE16454@atomide.com \
--to=tony@atomide.com \
--cc=khilman@mvista.com \
--cc=linux-omap-open-source@linux.omap.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.