From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IN8Mc-0007Pw-HX for mharc-grub-devel@gnu.org; Mon, 20 Aug 2007 10:36:18 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IN8Ma-0007Oa-Bn for grub-devel@gnu.org; Mon, 20 Aug 2007 10:36:16 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IN8MZ-0007Nu-6j for grub-devel@gnu.org; Mon, 20 Aug 2007 10:36:15 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IN8MY-0007No-Sv for grub-devel@gnu.org; Mon, 20 Aug 2007 10:36:15 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IN8MY-0007IY-5Z for grub-devel@gnu.org; Mon, 20 Aug 2007 10:36:14 -0400 Received: from [192.168.10.6] (helo=aragorn) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1IN8MV-0006C3-Ri for grub-devel@gnu.org; Mon, 20 Aug 2007 16:36:12 +0200 Received: from rmh by aragorn with local (Exim 4.63) (envelope-from ) id 1IN8MN-0000AX-LF for grub-devel@gnu.org; Mon, 20 Aug 2007 16:36:03 +0200 Date: Mon, 20 Aug 2007 16:36:03 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20070820143603.GA470@aragorn> References: <46BD54CF.2050800@gmail.com> <20070812144528.GC2260@aragorn> <46BF55BC.4020103@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <46BF55BC.4020103@gmail.com> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-Detected-Kernel: Genre and OS details not recognized. Subject: Re: Patch for boot message X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 20 Aug 2007 14:36:16 -0000 On Sun, Aug 12, 2007 at 11:47:24AM -0700, Mischa Spiegelmock wrote: > Robert Millan wrote: > >On Fri, Aug 10, 2007 at 11:18:55PM -0700, Mischa Spiegelmock wrote: > > > >>I got sick of grub saying "The highlighted entry will be booted > >>automatically in 1 seconds." > >> > >>Here's a patch: > >> > >>Index: normal/menu.c > >>=================================================================== > >>RCS file: /sources/grub/grub2/normal/menu.c,v > >>retrieving revision 1.18 > >>diff -r1.18 menu.c > >>331,332c331,332 > >>< The highlighted entry will be booted automatically in %d seconds. > >>", > >>< timeout); > >>--- > >> > >>> The highlighted entry will be booted automatically in %d > >>> > >>second%c ", > >> > >>> timeout, (timeout == 1 ? ' ' : 's')); > >>> > > > >This breaks l10n, and also adds a bogus ' ' (although that's a minor > >issue). > > > >The SI symbol for second is 's'. Why not using that instead? > > > > > Well whatever, I was just trying to fix the currently broken behavior. > As for adding the "bogus" ' ', that's keeping in line with the comment > on the line before: > > /* NOTE: Do not remove the trailing space characters. > They are required to clear the line. */ Ah, right. I see. > I just tried to do the least invasive patch that would keep the amount > of characters constant. I fixed it to use "s". Thanks for the correction -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)