From: Matthew Wilcox <matthew@wil.cx>
To: "Stephen C. Tweedie" <sct@redhat.com>
Cc: Chris Snook <csnook@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH 0/2] avoid clobbering registers with J_ASSERT macro
Date: Mon, 20 Aug 2007 09:46:48 -0600 [thread overview]
Message-ID: <20070820154648.GI30019@parisc-linux.org> (raw)
In-Reply-To: <1187623324.12049.4.camel@sisko.scot.redhat.com>
On Mon, Aug 20, 2007 at 04:22:04PM +0100, Stephen C. Tweedie wrote:
> Hi,
>
> On Mon, 2007-08-20 at 09:18 -0400, Chris Snook wrote:
>
> > > How's about we just remove that printk? Do
> > >
> > > #define J_ASSERT(e) BUG_ON(e)?
ITYM #define J_ASSERT(e) BUG_ON(!e)
> It did. The original J_ASSERT predates BUG() entirely, and was added so
> that we got the file/line-no information. But with the current BUG()
> macro, I can't see any reason for J_ASSERT still to try to gather that
> information itself.
Do you still want to keep J_ASSERT, or should all uses of it be replaced
with BUG_ON?
(to put it another way; if you were writing JBD now, would you add your
own J_ASSERT, or would you just use BUG_ON directly?)
--
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2007-08-20 15:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-17 5:54 [RFC PATCH 0/2] avoid clobbering registers with J_ASSERT macro Chris Snook
2007-08-17 6:02 ` [RFC PATCH 1/2] jbd: " Chris Snook
2007-08-17 6:04 ` [RFC PATCH 2/2] jbd2: " Chris Snook
2007-08-17 20:54 ` [RFC PATCH 0/2] " Andrew Morton
2007-08-20 13:18 ` Chris Snook
2007-08-20 15:22 ` Stephen C. Tweedie
2007-08-20 15:46 ` Matthew Wilcox [this message]
2007-08-20 16:19 ` Stephen C. Tweedie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070820154648.GI30019@parisc-linux.org \
--to=matthew@wil.cx \
--cc=akpm@linux-foundation.org \
--cc=csnook@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=sct@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.