All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eugene Teo <eugeneteo@kernel.sg>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] video/geode: fix warnings
Date: Tue, 21 Aug 2007 05:52:32 +0000	[thread overview]
Message-ID: <20070821055232.GB18465@kernel.sg> (raw)
In-Reply-To: <20070820230320.6741bb15@shaun>

<quote sender="Shaun Zinck">
> Remove the double declaration of variable 'opt'.
> 
> Signed-off-by: Shaun Zinck <shaun.zinck@gmail.com>
> ---
> This is my first patch so I mostly wanted to make sure I got the formatting right.
> Does this look OK?

Yes, the formatting is ok. Take a look at the following link:
http://lxr.linux.no/source/Documentation/SubmittingPatches#L331

Thanks,
Eugene

      parent reply	other threads:[~2007-08-21  5:52 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-21  4:03 [PATCH] video/geode: fix warnings Shaun Zinck
2007-08-21  5:35 ` Eugene Teo
2007-08-21  5:52 ` Eugene Teo [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070821055232.GB18465@kernel.sg \
    --to=eugeneteo@kernel.sg \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.