[PATCH] video/geode: fix warnings

[PATCH] video/geode: fix warnings

[Shaun Zinck]

Remove the double declaration of variable 'opt'.

Signed-off-by: Shaun Zinck <shaun.zinck@gmail.com>
---
This is my first patch so I mostly wanted to make sure I got the formatting right.
Does this look OK?

diff --git a/drivers/video/geode/lxfb_core.c b/drivers/video/geode/lxfb_core.c
index 5e30b40..67d6bf6 100644
--- a/drivers/video/geode/lxfb_core.c
+++ b/drivers/video/geode/lxfb_core.c
@@ -559,12 +559,10 @@ static struct pci_driver lxfb_driver = {
 };
 
 #ifndef MODULE
 static int __init lxfb_setup(char *options)
 {
-	char *opt;
-
 	if (!options || !*options)
 		return 0;
 
 	while (1) {
 		char *opt = strsep(&options, ",");

Re: [PATCH] video/geode: fix warnings

[Eugene Teo]

Hi Shaun,

<quote sender="Shaun Zinck">
> Remove the double declaration of variable 'opt'.
> 
> Signed-off-by: Shaun Zinck <shaun.zinck@gmail.com>

Thanks, but I have already submitted this patch sometime back:
http://article.gmane.org/gmane.linux.kernel.commits.mm/19286

Eugene

Re: [PATCH] video/geode: fix warnings

[Eugene Teo]

<quote sender="Shaun Zinck">
> Remove the double declaration of variable 'opt'.
> 
> Signed-off-by: Shaun Zinck <shaun.zinck@gmail.com>
> ---
> This is my first patch so I mostly wanted to make sure I got the formatting right.
> Does this look OK?

Yes, the formatting is ok. Take a look at the following link:
http://lxr.linux.no/source/Documentation/SubmittingPatches#L331

Thanks,
Eugene