All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 02/15] Make ccid3_hc_tx_update_x get a timestamp if needed
Date: Tue, 21 Aug 2007 06:51:10 +0000	[thread overview]
Message-ID: <200708210751.10567@strip-the-willow> (raw)
In-Reply-To: <20070819234901.GF24792@ghostprotocols.net>

|  The code was too complicated, if p > 0 in ccid3_hc_tx_no_feedback_timer the
|  timestamp was being obtained to be passed to ccid3_hc_tx_update_x, where only
|  if p > 0 the timestamp was needed, so just leave it to ccid3_hc_tx_update_x to
|  obtain the timestamp if needed.
The `too complicated' is there for a reason, it served to reduce the number of timestamps
per packet.

With your patch, the code is now back at taking two timestamps per each received packet:

 * first a timestamp is taken for the RTT sample
 * whenever p = 0 (normal condition without loss), the second timestamp is now
   taken in ccid3_hc_tx_update_x()

Since this code is in the receive path, it is executed for each received
packet, i.e. two timestamps per each incoming packet.

The original code recycled the first timestamp; the timestamp in no_feedback_timer()
(which is only executed in exception cases, when there is no feedback for over 4 RTTs) was
taken only when absolutely necessary, if two `if' conditions held.

But this is not a big deal - I will send a patch shortly.

      reply	other threads:[~2007-08-21  6:51 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-19 23:49 [PATCH 02/15] Make ccid3_hc_tx_update_x get a timestamp if needed Arnaldo Carvalho de Melo
2007-08-21  6:51 ` Gerrit Renker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200708210751.10567@strip-the-willow \
    --to=gerrit@erg.abdn.ac.uk \
    --cc=dccp@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.