All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jan Harkes <jaharkes@cs.cmu.edu>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/4] Fix mainline filesystems to handle ATTR_KILL_ bits correctly
Date: Tue, 21 Aug 2007 11:04:06 -0400	[thread overview]
Message-ID: <20070821150406.GA30675@cs.cmu.edu> (raw)
In-Reply-To: <200708202053.l7KKrMYv017763@dantu.rdu.redhat.com>

On Mon, Aug 20, 2007 at 04:53:22PM -0400, Jeff Layton wrote:
> This should fix all of the filesystems in the mainline kernels to handle
> ATTR_KILL_SUID and ATTR_KILL_SGID correctly. For most of them, this is
> just a matter of making sure that they call generic_attrkill early in
> the setattr inode op.
> 
> Signed-off-by: Jeff Layton <jlayton@redhat.com>

Coda part looks fine to me. Couldn't test it beyond 'it compiles and
doesn't oops', because our userspace client unconditionally strips
setuid/setgid bits anyways.

Acked-by: Jan Harkes <jaharkes@cs.cmu.edu>


      parent reply	other threads:[~2007-08-21 15:33 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-20 20:53 [Cluster-devel] [PATCH 2/4] Fix mainline filesystems to handle ATTR_KILL_ bits correctly Jeff Layton
2007-08-20 20:53 ` Jeff Layton
2007-08-20 20:53 ` Jeff Layton
2007-08-20 21:07 ` [Jfs-discussion] " Dave Kleikamp
2007-08-21  5:35 ` Timothy Shimmin
2007-08-21 11:35   ` Jeff Layton
2007-08-21 21:21     ` Josef Sipek
2007-08-21 22:23       ` Jeff Layton
2007-08-28  1:37         ` Timothy Shimmin
2007-08-21 15:04 ` Jan Harkes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070821150406.GA30675@cs.cmu.edu \
    --to=jaharkes@cs.cmu.edu \
    --cc=jlayton@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.