From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Christoph Egger" Subject: Re: [PATCH] 3/3: MCA/MCE correctable error handling Date: Wed, 22 Aug 2007 11:00:34 +0200 Message-ID: <200708221100.34795.Christoph.Egger@amd.com> References: <200708211531.44997.Christoph.Egger@amd.com> <46CB28CE.76E4.0078.0@novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Return-path: In-Reply-To: <46CB28CE.76E4.0078.0@novell.com> Content-Disposition: inline List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xensource.com Errors-To: xen-devel-bounces@lists.xensource.com To: xen-devel@lists.xensource.com Cc: Gavin.Maltby@sun.com, Keir Fraser , Jan Beulich List-Id: xen-devel@lists.xenproject.org On Tuesday 21 August 2007 18:02:54 Jan Beulich wrote: > >+ if (mc_global->mc_flags & MC_FLAG_UNCORRECTABLE) > >+ printk(KERN_EMERG); > >+ else > >+ printk(KERN_INFO); > > KERN_INFO seems gross understatement here - generally, correctable MCs are > considered indicators that within not too distant future uncorrectable MCs > might result, so this generally is a call for action (and hence shouldn't > be hidden with default log level settings). Well, that is what the "old" code did. It used KERN_EMERG for fatal errors and KERN_INFO in the polling service routine. What do you want me to sugges= t? > Also, I'm not sure adjusting the polling frequency makes much sense - 30s > seems an awful lot of time to me. It's not clear to me what you are trying to tell me. Please explain/elabora= te. Christoph =2D-=20 AMD Saxony, Dresden, Germany Operating System Research Center Legal Information: AMD Saxony Limited Liability Company & Co. KG Sitz (Gesch=E4ftsanschrift): Wilschdorfer Landstr. 101, 01109 Dresden, Deutschland Registergericht Dresden: HRA 4896 vertretungsberechtigter Komplement=E4r: AMD Saxony LLC (Sitz Wilmington, Delaware, USA) Gesch=E4ftsf=FChrer der AMD Saxony LLC: Dr. Hans-R. Deppe, Thomas McCoy