Re: [RFC][PATCH 4/4] hugetlb: add per-node nr_hugepages sysfs attribute

[Nishanth Aravamudan <nacc@us.ibm.com>]

On 13.08.2007 [10:55:46 -0700], Dave Hansen wrote:
> On Wed, 2007-08-08 at 17:52 -0700, Nishanth Aravamudan wrote:
> > 
> > +#ifdef CONFIG_NUMA
> > +int hugetlb_register_node(struct node *);
> > +void hugetlb_unregister_node(struct node *);
> > +#else
> > +#define hugetlb_register_node(node)            0
> > +#define hugetlb_unregister_node(node)          ((void)0)
> > +#endif 
> 
> This is to keep someone from doing:
> 
> 	ret = hugetlb_unregister_node(node);
> 
> ?
> 
> I think it's a little more standard to do:
> 
> 	#define hugetlb_unregister_node(node)          do {} while(0)

That's a good point. Now that I'm back from vacation, I'll make this
adjustment.

Thanks,
Nish

-- 
Nishanth Aravamudan <nacc@us.ibm.com>
IBM Linux Technology Center

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>