From: Al Viro <viro@ftp.linux.org.uk>
To: Divy Le Ray <divy@chelsio.com>
Cc: Jeff Garzik <jeff@garzik.org>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Steve Wise <swise@opengridcomputing.com>
Subject: Re: [PATCH 0/3] cxgb3 driver update
Date: Thu, 23 Aug 2007 08:02:16 +0100 [thread overview]
Message-ID: <20070823070216.GI21089@ftp.linux.org.uk> (raw)
In-Reply-To: <46CD2AA8.9070507@chelsio.com>
On Wed, Aug 22, 2007 at 11:35:20PM -0700, Divy Le Ray wrote:
> Hi Jeff,
>
> I'm submitting three more patches for inclusion in netdev#upstream.
> These patches are built over the series I resent yesterday night.
> The patch numbering reflects the stacking.
>
> Here is a brief description:
> - avoid false positives in the xgmac hang workaround
> - Properly set the CQ_ERR bit in RDMA CQ contexts.
> - Update CQ context operations time out values
Speaking of cxgb3, could you explain what the hell is
static int do_term(struct t3cdev *dev, struct sk_buff *skb)
{
unsigned int hwtid = ntohl(skb->priority) >> 8 & 0xfffff;
doing? AFAIK, skb->priority is not net-endian...
Another odd place is
int t3_seeprom_write(struct adapter *adapter, u32 addr, u32 data)
{
u16 val;
int attempts = EEPROM_MAX_POLL;
unsigned int base = adapter->params.pci.vpd_cap_addr;
if ((addr >= EEPROMSIZE && addr != EEPROM_STAT_ADDR) || (addr & 3))
return -EINVAL;
pci_write_config_dword(adapter->pdev, base + PCI_VPD_DATA,
cpu_to_le32(data));
with callers like
int t3_seeprom_wp(struct adapter *adapter, int enable)
{
return t3_seeprom_write(adapter, EEPROM_STAT_ADDR, enable ? 0xc : 0);
IOW, you really get little-endian values passed to pci_write_config_dword()
and it expects a host-endian as the last argument...
next prev parent reply other threads:[~2007-08-23 7:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-23 6:35 [PATCH 0/3] cxgb3 driver update Divy Le Ray
2007-08-23 7:02 ` Al Viro [this message]
2007-08-23 22:03 ` Divy Le Ray
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070823070216.GI21089@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=divy@chelsio.com \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.