All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krishna Kumar <krkumar2@in.ibm.com>
To: netdev@vger.kernel.org, davem@davemloft.net
Cc: Krishna Kumar <krkumar2@in.ibm.com>
Subject: [PATCH 2/2] [RFC] E1000: Fix hang in netdev_wait_allrefs()
Date: Thu, 23 Aug 2007 14:34:31 +0530	[thread overview]
Message-ID: <20070823090431.13099.2597.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20070823090418.13099.89298.sendpatchset@localhost.localdomain>

After applying patch1, I started getting "waiting for count" messages when
doing ifdown. Not sure if this is the right fix since the count was already
showing as -1 in that message, but this patch fixes the problem.

Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
---
 e1000_main.c |    3 ++-
 1 files changed, 2 insertions(+), 1 deletion(-)

diff -ruNp new/drivers/net/e1000/e1000_main.c new2/drivers/net/e1000/e1000_main.c
--- new/drivers/net/e1000/e1000_main.c	2007-08-23 13:32:34.000000000 +0530
+++ new2/drivers/net/e1000/e1000_main.c	2007-08-23 14:28:12.000000000 +0530
@@ -1219,12 +1219,13 @@ e1000_remove(struct pci_dev *pdev)
 	 * would have already happened in close and is redundant. */
 	e1000_release_hw_control(adapter);
 
-	unregister_netdev(netdev);
 #ifdef CONFIG_E1000_NAPI
 	for (i = 0; i < adapter->num_rx_queues; i++)
 		dev_put(&adapter->polling_netdev[i]);
 #endif
 
+	unregister_netdev(netdev);
+
 	if (!e1000_check_phy_reset_block(&adapter->hw))
 		e1000_phy_hw_reset(&adapter->hw);
 

  reply	other threads:[~2007-08-23  9:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-23  9:04 [PATCH 1/2] E1000: Fix ifdown hang in git-2.6.24 Krishna Kumar
2007-08-23  9:04 ` Krishna Kumar [this message]
2007-08-25  6:08   ` [PATCH 2/2] [RFC] E1000: Fix hang in netdev_wait_allrefs() David Miller
2007-08-23 16:11 ` [PATCH 1/2] E1000: Fix ifdown hang in git-2.6.24 Kok, Auke
2007-08-25  6:07 ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070823090431.13099.2597.sendpatchset@localhost.localdomain \
    --to=krkumar2@in.ibm.com \
    --cc=davem@davemloft.net \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.