Re: [PATCH] Console events and accessibility

[Greg KH <greg@kroah.com>]

On Wed, Aug 22, 2007 at 03:05:20PM +0200, Samuel Thibault wrote:
> Samuel Thibault, le Wed 22 Aug 2007 10:53:55 +0200, a ?crit :
> > Greg KH, le Tue 21 Aug 2007 22:48:55 -0700, a ?crit :
> > > On Tue, Aug 21, 2007 at 11:29:39PM +0200, Samuel Thibault wrote:
> > > > Some external modules like Speakup need to monitor console output.
> > > > 
> > > > This adds a VT notifier that such modules can use to get console output events:
> > > > allocation, deallocation, writes, other updates (cursor position, switch, etc.)
> > > > 
> > > > Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
> > > 
> > > Will speakup work with this kind of change?
> > 
> > Here are the last needed bits.
> 
> I mean: yes, with these three patches, speakup will work fine.

3 patches?  I only saw 2.  Or do you mean the modifications of the 3
files?

The patches look sane but you should change the global symbols to play
nicer in the namespace.  Care to respin them together with this change?

> The biggest change we'll have to do in speakup is the way it accesses
> the serial port, which is really dirty for now, but that's an internal
> matter.

Yeah, that shouldn't be that tough to do.

It doesn't look like these changes handle scrolling of the console, do
they?  If so, don't you need to do more?  I had some old patches around
here that had devices that wanted to know cursor positioning, which I
don't think this hook can handle :(

thanks,

greg k-h