From: pcaulfield@sourceware.org <pcaulfield@sourceware.org>
To: lvm-devel@redhat.com
Subject: LVM2 lib/locking/cluster_locking.c daemons/clv ...
Date: 23 Aug 2007 15:43:20 -0000 [thread overview]
Message-ID: <20070823154320.5472.qmail@sourceware.org> (raw)
CVSROOT: /cvs/lvm2
Module name: LVM2
Changes by: pcaulfield at sourceware.org 2007-08-23 15:43:20
Modified files:
lib/locking : cluster_locking.c
daemons/clvmd : clvmd-command.c
Log message:
Locking P_global causes a cache refresh.
Patches:
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/lib/locking/cluster_locking.c.diff?cvsroot=lvm2&r1=1.20&r2=1.21
http://sourceware.org/cgi-bin/cvsweb.cgi/LVM2/daemons/clvmd/clvmd-command.c.diff?cvsroot=lvm2&r1=1.17&r2=1.18
--- LVM2/lib/locking/cluster_locking.c 2007/08/23 15:02:26 1.20
+++ LVM2/lib/locking/cluster_locking.c 2007/08/23 15:43:19 1.21
@@ -330,11 +330,14 @@
* locks are cluster-wide.
* Also, if the lock is exclusive it makes no sense to try to
* acquire it on all nodes, so just do that on the local node too.
+ * One exception, is that P_ locks /do/ get distributed across
+ * the cluster because they might have side-effects.
*/
- if (cmd == CLVMD_CMD_LOCK_VG ||
- (flags & LCK_TYPE_MASK) == LCK_EXCL ||
- (flags & LCK_LOCAL) ||
- !(flags & LCK_CLUSTER_VG))
+ if (strncmp(name, "P_", 2) &&
+ (cmd == CLVMD_CMD_LOCK_VG ||
+ (flags & LCK_TYPE_MASK) == LCK_EXCL ||
+ (flags & LCK_LOCAL) ||
+ !(flags & LCK_CLUSTER_VG)))
node = ".";
status = _cluster_request(cmd, node, args, len,
--- LVM2/daemons/clvmd/clvmd-command.c 2007/08/17 11:51:23 1.17
+++ LVM2/daemons/clvmd/clvmd-command.c 2007/08/23 15:43:20 1.18
@@ -115,8 +115,13 @@
break;
case CLVMD_CMD_LOCK_VG:
+ lockname = &args[2];
/* Check to see if the VG is in use by LVM1 */
- status = do_check_lvm1(&args[2]);
+ status = do_check_lvm1(lockname);
+ /* P_global causes a cache refresh */
+ if (strcmp(lockname, "P_global") == 0)
+ do_refresh_cache();
+
break;
case CLVMD_CMD_LOCK_LV:
reply other threads:[~2007-08-23 15:43 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070823154320.5472.qmail@sourceware.org \
--to=pcaulfield@sourceware.org \
--cc=lvm-devel@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.