All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@suse.de>
To: linux-kernel@vger.kernel.org, stable@kernel.org
Cc: Justin Forbes <jmforbes@linuxtx.org>,
	Zwane Mwaikambo <zwane@arm.linux.org.uk>,
	"Theodore Ts'o" <tytso@mit.edu>,
	Randy Dunlap <rdunlap@xenotime.net>,
	Dave Jones <davej@redhat.com>,
	Chuck Wolber <chuckw@quantumlinux.com>,
	Chris Wedgwood <reviews@ml.cw.f00f.org>,
	Michael Krufky <mkrufky@linuxtv.org>,
	Chuck Ebbert <cebbert@redhat.com>,
	Domenico Andreoli <cavokz@gmail.com>,
	torvalds@linux-foundation.org, akpm@linux-foundation.org,
	alan@lxorguk.ukuu.org.uk, bunk@stusta.de,
	Konstantin Sharlaimov <konstantin.sharlaimov@gmail.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: [patch 20/28] PPP: Fix PPP buffer sizing.
Date: Thu, 23 Aug 2007 15:27:30 -0700	[thread overview]
Message-ID: <20070823222730.GT18559@kroah.com> (raw)
In-Reply-To: <20070823221811.GA18559@kroah.com>

[-- Attachment #1: ppp-fix-ppp-buffer-sizing.patch --]
[-- Type: text/plain, Size: 1383 bytes --]

-stable review patch.  If anyone has any objections, please let us know.

------------------

From: Konstantin Sharlaimov <konstantin.sharlaimov@gmail.com>

This patch addresses the issue with "osize too small" errors in mppe
encryption.  The patch fixes the issue with wrong output buffer size
being passed to ppp decompression routine.

--------------------
As pointed out by Suresh Mahalingam, the issue addressed by
ppp-fix-osize-too-small-errors-when-decoding patch is not fully resolved yet.
The size of allocated output buffer is correct, however it size passed to
ppp->rcomp->decompress in ppp_generic.c if wrong. The patch fixes that.
--------------------

Signed-off-by: Konstantin Sharlaimov <konstantin.sharlaimov@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/net/ppp_generic.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/net/ppp_generic.c
+++ b/drivers/net/ppp_generic.c
@@ -1726,7 +1726,7 @@ ppp_decompress_frame(struct ppp *ppp, st
 		}
 		/* the decompressor still expects the A/C bytes in the hdr */
 		len = ppp->rcomp->decompress(ppp->rc_state, skb->data - 2,
-				skb->len + 2, ns->data, ppp->mru + PPP_HDRLEN);
+				skb->len + 2, ns->data, obuff_size);
 		if (len < 0) {
 			/* Pass the compressed frame to pppd as an
 			   error indication. */

-- 

  parent reply	other threads:[~2007-08-23 22:37 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20070823220656.101239233@mini.kroah.org>
2007-08-23 22:18 ` [patch 00/28] 2.6.22-stable review cycle again Greg KH
2007-08-23 22:25   ` [patch 01/28] ocfs2: Fix bad source start calculation during kernel writes Greg KH
2007-08-23 22:25   ` [patch 02/28] NET: Share correct feature code between bridging and bonding Greg KH
2007-08-23 22:26   ` [patch 03/28] sky2: dont clear phy power bits Greg KH
2007-08-23 22:26   ` [patch 04/28] uml: fix previous request size limit fix Greg KH
2007-08-23 22:26   ` [patch 05/28] i386: fix lazy mode vmalloc synchronization for paravirt Greg KH
2007-08-23 22:26   ` [patch 06/28] signalfd: fix interaction with posix-timers Greg KH
2007-08-23 22:26   ` [patch 07/28] signalfd: make it group-wide, fix posix-timers scheduling Greg KH
2007-08-23 22:26   ` [patch 08/28] DCCP: Fix DCCP GFP_KERNEL allocation in atomic context Greg KH
2007-08-23 22:26   ` [patch 09/28] IPV6: Fix kernel panic while send SCTP data with IP fragments Greg KH
2007-08-23 22:26   ` [patch 10/28] IPv6: Invalid semicolon after if statement Greg KH
2007-08-23 22:26   ` [patch 11/28] Fix soft-fp underflow handling Greg KH
2007-08-23 22:26   ` [patch 12/28] Netfilter: Missing Kbuild entry for netfilter Greg KH
2007-08-23 22:26   ` [patch 13/28] SNAP: Fix SNAP protocol header accesses Greg KH
2007-08-23 22:27   ` [patch 14/28] NET: Fix missing rcu unlock in __sock_create() Greg KH
2007-08-23 22:27   ` [patch 15/28] SPARC64: Fix sparc64 task stack traces Greg KH
2007-08-23 22:27   ` [patch 16/28] SPARC64: Fix sparc64 PCI config accesses on sun4u Greg KH
2007-08-23 22:27   ` [patch 18/28] TCP: Fix TCP rate-halving on bidirectional flows Greg KH
2007-08-23 22:27   ` [patch 19/28] TCP: Fix TCP handling of SACK in " Greg KH
2007-08-23 22:27   ` Greg KH [this message]
2007-08-23 22:27   ` [patch 21/28] PCI: lets kill the PCI hidden behind bridge message Greg KH
2007-08-23 22:27   ` [patch 22/28] PCI: disable MSI on RS690 Greg KH
2007-08-23 22:27   ` [patch 23/28] PCI: disable MSI on RD580 Greg KH
2007-08-23 22:27   ` [patch 24/28] PCI: disable MSI on RX790 Greg KH
2007-08-23 22:27   ` [patch 25/28] USB: cdc-acm: fix sysfs attribute registration bug Greg KH
2007-08-24 13:59     ` Alan Stern
2007-08-24 15:49       ` [stable] " Greg KH
2007-08-24 17:59         ` Alan Stern
2007-08-24 18:04           ` Greg KH
2007-08-29 18:48             ` Chuck Ebbert
2007-08-29 23:33             ` Chuck Ebbert
2007-08-31  5:10               ` Greg KH
2007-08-23 22:27   ` [patch 26/28] USB: allow retry on descriptor fetch errors Greg KH
2007-08-23 22:27   ` [patch 27/28] USB: fix DoS in pwc USB video driver Greg KH
2007-08-23 22:28   ` [patch 28/28] usb: add PRODUCT, TYPE to usb-interface events Greg KH
2007-08-23 22:29   ` [patch 17/28] TCP: Do not autobind ports for TCP sockets Greg KH
2007-08-23 22:32   ` [patch 00/28] 2.6.22-stable review cycle again Greg KH
2007-08-29 19:43   ` Thomas Backlund
2007-08-29 20:03     ` Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070823222730.GT18559@kroah.com \
    --to=gregkh@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=bunk@stusta.de \
    --cc=cavokz@gmail.com \
    --cc=cebbert@redhat.com \
    --cc=chuckw@quantumlinux.com \
    --cc=davej@redhat.com \
    --cc=davem@davemloft.net \
    --cc=jmforbes@linuxtx.org \
    --cc=konstantin.sharlaimov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mkrufky@linuxtv.org \
    --cc=rdunlap@xenotime.net \
    --cc=reviews@ml.cw.f00f.org \
    --cc=stable@kernel.org \
    --cc=torvalds@linux-foundation.org \
    --cc=tytso@mit.edu \
    --cc=zwane@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.