Re: [PATCH] ACPI: add "Fujitsu laptop extras" module

[Matthew Garrett <mjg59@srcf.ucam.org>]

On Fri, Aug 24, 2007 at 11:55:41AM +0800, Zhang Rui wrote:

> I have the same question for ACPI video driver.
> Take KEY_BRIGHTNESSUP/KEY_BRIGHTNESSDOWN for example, if ACPI video
> driver gets such a notification, it will change the brightness level
> first and then send an event to user space.

The X people would prefer that the kernel not change the brightness 
itself, where possible. In the cases where drivers know how to control 
the backlight hardware themselves (most new Intel hardware, nvidia stuff 
since 2005ish, that sort of thing) it's likely that they'll be able to 
provide much more control than the level provided via the ACPI 
interface.

> I'll send a patch to make ACPI video driver do nothing but export the
> events to user space in the notify handler if you guys think it's okay.

I think that's the right thing to do, but you might want to make it a 
module option to begin with. That way you can printk that the behaviour 
will change in the future, and then flip the default in a few months.

-- 
Matthew Garrett | mjg59@srcf.ucam.org