From: Paul Mundt <lethal@linux-sh.org>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: what is the value of the macro "__setup_param"?
Date: Fri, 24 Aug 2007 18:50:58 +0900 [thread overview]
Message-ID: <20070824095058.GA32013@linux-sh.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0708240516080.14019@localhost.localdomain>
On Fri, Aug 24, 2007 at 05:19:29AM -0400, Robert P. J. Day wrote:
>
> perhaps i'm missing it, but it seems that the macro __setup_param is
> entirely superfluous:
>
> $ grep -rw __setup_param *
> include/linux/init.h:#define __setup_param(str, unique_id, fn, early) \
> include/linux/init.h: __setup_param(str, unique_id, NULL, 0)
> include/linux/init.h: __setup_param(str, fn, fn, 0)
> include/linux/init.h: __setup_param(str, fn, fn, 1)
> include/linux/init.h:#define __setup_param(str, unique_id, fn) /* nothing */
> $
>
> or am i must misreading something badly?
>
Superfluous how? It does different things depending on whether MODULE is
defined or not. It's a good indicator of how often people use
__setup_param() from module context though, given the complete mismatch
of parameters. It's probably worth fixing that up at least.
next prev parent reply other threads:[~2007-08-24 9:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-24 9:19 what is the value of the macro "__setup_param"? Robert P. J. Day
2007-08-24 9:37 ` Adrian Bunk
2007-08-24 9:32 ` Robert P. J. Day
2007-08-24 9:50 ` Paul Mundt [this message]
2007-08-24 9:49 ` Robert P. J. Day
2007-08-24 10:02 ` Paul Mundt
2007-08-24 10:01 ` Robert P. J. Day
2007-08-24 11:29 ` Satyam Sharma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070824095058.GA32013@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@mindspring.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.