Re: Cannot stall an endpoint 0 control transfer from a data stage cal lback function

[Tony Lindgren <tony@atomide.com>]

* David Brownell <david-b@pacbell.net> [070821 16:58]:
> On Tuesday 21 August 2007, Geoffrey Tam wrote:
> > Sorry for the long delay.
> > 
> > I just tried out the latest code on the git tree, and it does not work for
> > me. It does not allow me to stall an endpoint.
> 
> I was wondering what happened to this problem report ... I cleaned
> up your old patch and fixed some things that were wrong, maybe this
> one will work better.
> 
> - Dave
> 
> 
> 
> ======	CUT HERE
> Gadget drivers are supposed to be able to cause EP0 protocol stalls by
> issuing an appropriate request from the callback issued when the DATA
> stage completes ... not only from the setup() callback or from some
> thread that decides how to handle the request.
> 
> This fix is based on a patch from Geoffrey Tam <geoffrey@evertz.com>,
> and addresses that by updating the endpoint state AFTER the callback
> is issued, providing the correct IRQ-acking CSR to the halt() so it
> can just mask in the SEND_STALL bit, and ensuring that only the CSR
> is still written only once even on this new code path.
> 
> Also includes a few small cleanups:  avoid "this" variable name, and
> pack device bitfields more efficiently (wasting less space).
> 
> Allegedly helps file_storage on Davinci.

I've pushed this as the driver seems to work after the patch :)

Tony