From: Andrew Morton <akpm@linux-foundation.org>
To: "Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net>
Cc: jens.axboe@oracle.com, linux-kernel@vger.kernel.org,
linux-scsi@vger.linux.org, hch@infradead.org,
james.bottomley@steeleye.com
Subject: Re: [PATCH 1/1] cciss: fix error reporting for SG_IO
Date: Fri, 24 Aug 2007 17:10:47 -0700 [thread overview]
Message-ID: <20070824171047.77cf7adc.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070824175354.GA14125@beardog.cca.cpqcorp.net>
On Fri, 24 Aug 2007 12:53:54 -0500
"Mike Miller (OS Dev)" <mikem@beardog.cca.cpqcorp.net> wrote:
> This fixes a problem with the way cciss was filling out the "errors"
> field of the request structure upon completion of requests.
> Previously, it just put a 1 or a 0 in there and used the negation
> of this as the uptodate parameter to one of the functions in the
> block layer, being a block device. For the SG_IO ioctl, this was not
> sufficient, and we noticed that, for example, sg_turs from sg3_utils
> did not correctly detect problems due to cciss having set rq->errors
> incorrectly.
Do we think this problem is sufficiently serious to merit merging
this (largeish) patch into 2.6.23?
I'm thinking "no", but that might be wrong...
next prev parent reply other threads:[~2007-08-25 0:11 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-24 17:53 [PATCH 1/1] cciss: fix error reporting for SG_IO Mike Miller (OS Dev)
2007-08-25 0:10 ` Andrew Morton [this message]
2007-08-27 19:58 ` Mike Miller (OS Dev)
-- strict thread matches above, loose matches on Subject: below --
2007-08-14 19:53 Mike Miller (OS Dev)
2007-08-16 14:53 ` Cameron, Steve
2007-08-16 14:53 ` Cameron, Steve
2007-08-24 10:24 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070824171047.77cf7adc.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=james.bottomley@steeleye.com \
--cc=jens.axboe@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.linux.org \
--cc=mikem@beardog.cca.cpqcorp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.