All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@ftp.linux.org.uk>
To: "Robert P. J. Day" <rpjday@mindspring.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] FS: Make RAMFS both selectable and tristate.
Date: Sat, 25 Aug 2007 22:59:45 +0100	[thread overview]
Message-ID: <20070825215945.GC21089@ftp.linux.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0708251736050.12852@localhost.localdomain>

On Sat, Aug 25, 2007 at 05:40:00PM -0400, Robert P. J. Day wrote:
> On Sat, 25 Aug 2007, Al Viro wrote:
> 
> > On Sat, Aug 25, 2007 at 03:40:23PM -0400, Robert P. J. Day wrote:
> > >
> > > Allow RAMFS to be user-selectable, and to be built as a module.
> > >
> > > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> > >
> > > ---
> > >
> > >   given that the help content for that option suggests it can be built
> > > as a module, it just makes sense to make it selectable and tristate,
> > > unless someone has a compelling argument against it.
> >
> > How about "check if the kernel builds if you do that"?
> 
> i did.  i did a simple "make defconfig" and "make", and the kernel
> built fine.  that patch didn't change the status of RAMFS in any way,
> it was still selected as default "y", so why would that patch have
> made any difference to the eventual build?

Your patch allows to make it a module.  That seems to be the only point of
your patch.  So check if it builds when RAMFS is made "m" or "n".

  reply	other threads:[~2007-08-25 21:59 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-25 19:40 [PATCH] FS: Make RAMFS both selectable and tristate Robert P. J. Day
2007-08-25 21:29 ` Al Viro
2007-08-25 21:40   ` Robert P. J. Day
2007-08-25 21:59     ` Al Viro [this message]
2007-08-25 21:43   ` Robert P. J. Day

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070825215945.GC21089@ftp.linux.org.uk \
    --to=viro@ftp.linux.org.uk \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rpjday@mindspring.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.