All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: "Jari Aalto" <jari.aalto@cante.net>,
	"Git Mailing List" <git@vger.kernel.org>,
	"Lukas Sandström" <lukass@etek.chalmers.se>
Subject: Re: [PATCH] In Examples, explain option -r and refer to git-rev-list[1]
Date: Mon, 27 Aug 2007 04:44:23 -0400	[thread overview]
Message-ID: <20070827084423.GA19230@coredump.intra.peff.net> (raw)
In-Reply-To: <7vbqctl6ky.fsf@gitster.siamese.dyndns.org>

On Mon, Aug 27, 2007 at 01:33:49AM -0700, Junio C Hamano wrote:

> --- a/builtin-log.c
> +++ b/builtin-log.c
> @@ -258,6 +258,7 @@ int cmd_log(int argc, const char **argv, const char *prefix)
>  	git_config(git_log_config);
>  	init_revisions(&rev, prefix);
>  	rev.always_show_header = 1;
> +	rev.diffopt.recursive = 1;
>  	cmd_log_init(argc, argv, prefix, &rev);
>  	return cmd_log_walk(&rev);
>  }

This should perhaps rather go in cmd_log_init (and be removed from
cmd_show and cmd_whatchanged). I think this is semantically a little
more clear, and the change will affect other log porcelains (right now
just "git-reflog --name-status", but also new ones if they are added).

But yes, this is post-1.5.3, so I will shut up rather than nitpicking
your "not meant to be applied now" patches.

-Peff

  reply	other threads:[~2007-08-27  8:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-26 15:40 [PATCH] In Examples, explain option -r and refer to git-rev-list[1] Jari Aalto
2007-08-27  8:02 ` Lukas Sandström
2007-08-27  8:14   ` Junio C Hamano
2007-08-27  8:33     ` Junio C Hamano
2007-08-27  8:44       ` Jeff King [this message]
2007-08-27  9:55         ` Junio C Hamano
2007-08-27 10:02           ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070827084423.GA19230@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jari.aalto@cante.net \
    --cc=lukass@etek.chalmers.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.