All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Daniel P. Berrange" <berrange@redhat.com>
To: Ben Guthro <bguthro@virtualiron.com>
Cc: Dave Lively <dlively@virtualiron.com>, xen-devel@lists.xensource.com
Subject: Re: [PATCH][QEMU] Allow more IDE power management
Date: Mon, 27 Aug 2007 20:19:48 +0100	[thread overview]
Message-ID: <20070827191948.GG9043@redhat.com> (raw)
In-Reply-To: <46D31BD4.3040802@virtualiron.com>

On Mon, Aug 27, 2007 at 02:45:40PM -0400, Ben Guthro wrote:
> Made the QEMU IDE disk tolerate more power-mgmt commands, specifically:
> 	WIN_SETFEATURE(EN_AAM)	- enable automatic acoustic mgmt
> 	WIN_SETFEATURE(DIS_AAM)	- disable automatic acoustic mgmt
> 	WIN_SETFEATURE(DIS_APM)	- disable automatic power mgmt
> 	WIN_STANDBY
> 	WIN_SETIDLE1
> 	WIN_SLEEPNOW1
> 	WIN_STANDBY2
> 	WIN_SETIDLE2
> 	WIN_SLEEPNOW2
> 	WIN_STANDBYNOW2
> These are all essentially no-ops, like existing support for EN_RLA (enable
> read lookahead) and WIN_STANDBYNOW1.
> 
> This fixes a crash in the SLES9-SP3 64bit kernel when the powersaved was
> started (with ACPI or ACM).  This guest really only needs EN_AAM, DIS_APM,
> and WIN_SETIDLE1 support, but the others seemed sensible to include.
> 
> I've excluded EN_APM since I'm unsure of what that's agreeing to do.  It's
> probably ok to include.

This and other QEMU patches should really be sent to upstream QEMU for review
and inclusion first so we don't have to maintain extra patches in Xen forever.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

      reply	other threads:[~2007-08-27 19:19 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-27 18:45 [PATCH][QEMU] Allow more IDE power management Ben Guthro
2007-08-27 19:19 ` Daniel P. Berrange [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070827191948.GG9043@redhat.com \
    --to=berrange@redhat.com \
    --cc=bguthro@virtualiron.com \
    --cc=dlively@virtualiron.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.