All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Hugh Dickins <hugh@veritas.com>
Cc: linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: fix bogus hotplug cpu warning
Date: Tue, 28 Aug 2007 12:18:01 +0200	[thread overview]
Message-ID: <20070828101801.GA27153@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.64.0708281022440.17987@blonde.wat.veritas.com>


* Hugh Dickins <hugh@veritas.com> wrote:

> > so if this check triggered for the cpu-offline code it's because 
> > keventd was _not_ per-cpu (perhaps because the cpu offline code 
> > broke its affinity?). So your patch hides a real bug.
> 
> No, keventd is properly per-cpu, but the task which is calling 
> current_is_keventd() is a normal user task, so smp_processor_id() did 
> warn about it.  It wouldn't make much sense to have a function 
> current_is_keventd() if you could only call it from a keventd, would 
> it ;-?  Take a look at it (kernel/workqueue.c), I believe what it does 
> is unusual (hence that comment about being "preempt-safe") but valid.

ok, you are right indeed.

	Ingo

      reply	other threads:[~2007-08-28 10:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-28  9:07 fix bogus hotplug cpu warning Ingo Molnar
2007-08-28  9:30 ` Hugh Dickins
2007-08-28 10:18   ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070828101801.GA27153@elte.hu \
    --to=mingo@elte.hu \
    --cc=hugh@veritas.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.