From: Jean Delvare <khali@linux-fr.org>
To: lm-sensors@vger.kernel.org
Subject: Re: [lm-sensors] [PATCH 4/8] sis5595: re-use s_bridge->revision
Date: Tue, 28 Aug 2007 10:23:27 +0000 [thread overview]
Message-ID: <20070828122327.6fa219cc@hyperion.delvare> (raw)
In-Reply-To: <20070827231655.27448.9252.stgit@localhost.localdomain>
Hi Auke,
On Mon, 27 Aug 2007 16:17:01 -0700, Auke Kok wrote:
> Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
> Cc: lm-sensors@lm-sensors.org
> ---
>
> drivers/hwmon/sis5595.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/hwmon/sis5595.c b/drivers/hwmon/sis5595.c
> index 92956eb..3d20a0c 100644
> --- a/drivers/hwmon/sis5595.c
> +++ b/drivers/hwmon/sis5595.c
> @@ -517,7 +517,7 @@ static int __devinit sis5595_probe(struct platform_device *pdev)
> platform_set_drvdata(pdev, data);
>
> /* Check revision and pin registers to determine whether 4 or 5 voltages */
> - pci_read_config_byte(s_bridge, PCI_REVISION_ID, &data->revision);
> + data->revision = s_bridge->revision;
> /* 4 voltages, 1 temp */
> data->maxins = 3;
> if (data->revision >= REV2MIN) {
I didn't know this revision field existed. Good cleanup, thanks.
Acked-by: Jean Delvare <khali@linux-fr.org>
--
Jean Delvare
_______________________________________________
lm-sensors mailing list
lm-sensors@lm-sensors.org
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
next prev parent reply other threads:[~2007-08-28 10:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-27 23:17 [lm-sensors] [PATCH 4/8] sis5595: re-use s_bridge->revision Auke Kok
2007-08-28 10:23 ` Jean Delvare [this message]
2007-08-28 15:40 ` Kok, Auke
2007-09-09 15:24 ` Mark M. Hoffman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070828122327.6fa219cc@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.