From: Ralf Baechle <ralf@linux-mips.org>
To: Atsushi Nemoto <anemo@mba.ocn.ne.jp>
Cc: linux-mips@linux-mips.org
Subject: Re: [MIPS] PCI: Remove __devinit attribute from pcibios_fixup_bus.
Date: Tue, 28 Aug 2007 16:05:31 +0100 [thread overview]
Message-ID: <20070828150531.GG11607@linux-mips.org> (raw)
In-Reply-To: <20070825.002328.108738360.anemo@mba.ocn.ne.jp>
On Sat, Aug 25, 2007 at 12:23:28AM +0900, Atsushi Nemoto wrote:
> On Fri, 24 Aug 2007 02:19:57 +0100, linux-mips@linux-mips.org wrote:
> > Author: Ralf Baechle <ralf@linux-mips.org> Thu Aug 23 14:12:56 2007 +0100
> > Commit: dda571e0032731ed05b65e365283c54522483b08
> > Gitweb: http://www.linux-mips.org/g/linux/dda571e0
> > Branch: master
> >
> > Since 96bde06a2df1b363206d3cdef53134b84ff37813 pcibios_fixup_bus's caller
> > pci_scan_child_bus is no longer marked __devinit resulting in this modpost
> > warning if PCI && !HOTPLUG:
>
> And pci_read_bridge_bases() called by pcibios_fixup_bus is still
> marked __devinit.
>
> Should we drop __devinit from pci_read_bridge_bases() too?
I already sent such a patch to gregkh on 23/8, so it'll just take a little
bit until this patch has propagated to Linus.
Ralf
prev parent reply other threads:[~2007-08-28 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <S20023984AbXHXBUC/20070824012002Z+18840@ftp.linux-mips.org>
2007-08-24 15:23 ` [MIPS] PCI: Remove __devinit attribute from pcibios_fixup_bus Atsushi Nemoto
2007-08-28 15:05 ` Ralf Baechle [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070828150531.GG11607@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.