From: Olof Johansson <olof@lixom.net>
To: Valentine Barshak <vbarshak@ru.mvista.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 3/4] PowerPC 440EPx: Sequoia board support
Date: Tue, 28 Aug 2007 13:14:37 -0500 [thread overview]
Message-ID: <20070828181437.GA14905@lixom.net> (raw)
In-Reply-To: <20070828175022.GA7556@ru.mvista.com>
Hi,
On Tue, Aug 28, 2007 at 09:50:22PM +0400, Valentine Barshak wrote:
> diff -ruN linux-2.6.orig/arch/powerpc/kernel/head_44x.S linux-2.6/arch/powerpc/kernel/head_44x.S
> --- linux-2.6.orig/arch/powerpc/kernel/head_44x.S 2007-08-27 14:08:43.000000000 +0400
> +++ linux-2.6/arch/powerpc/kernel/head_44x.S 2007-08-28 17:04:51.000000000 +0400
> @@ -217,7 +217,7 @@
> lis r4,interrupt_base@h /* IVPR only uses the high 16-bits */
> mtspr SPRN_IVPR,r4
>
> -#ifdef CONFIG_440EP
> +#if defined(CONFIG_440EP) || defined(CONFIG_440EPX)
> /* Clear DAPUIB flag in CCR0 (enable APU between CPU and FPU) */
> mfspr r2,SPRN_CCR0
> lis r3,0xffef
This is obviously nothing urgent given that the ifdef already existed, but
this looks like it really should be a runtime check instead. Multiplatform
kernels will require it (if/whenever that becomes a priority for 44x).
-Olof
next prev parent reply other threads:[~2007-08-28 19:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-28 16:53 [PATCH 0/4] PowerPC 440EPx: Initial Sequoia support take 3 Valentine Barshak
2007-08-28 16:56 ` [PATCH 1/4] PowerPC 440EPx: Sequoia bootwrapper Valentine Barshak
2007-08-28 18:09 ` Josh Boyer
2007-08-29 12:10 ` Valentine Barshak
2007-08-29 12:28 ` Stefan Roese
2007-08-29 12:26 ` Josh Boyer
2007-08-29 6:33 ` David Gibson
2007-08-29 12:13 ` Valentine Barshak
2007-08-28 16:58 ` [PATCH 2/4] PowerPC 440EPx: Sequoia device tree Valentine Barshak
2007-08-28 17:00 ` [PATCH 3/4] PowerPC 440EPx: Sequoia board support Valentine Barshak
2007-08-28 17:48 ` Josh Boyer
2007-08-28 17:50 ` Valentine Barshak
2007-08-28 18:14 ` Olof Johansson [this message]
2007-08-28 19:13 ` Josh Boyer
2007-08-28 17:01 ` [PATCH 4/4] PowerPC 440EPx: Sequoia defconfig Valentine Barshak
-- strict thread matches above, loose matches on Subject: below --
2007-08-29 13:35 [PATCH 0/4] PowerPC 440EPx: Initial Sequoia support Valentine Barshak
2007-08-29 13:40 ` [PATCH 3/4] PowerPC 440EPx: Sequoia board support Valentine Barshak
2007-08-30 0:37 ` David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070828181437.GA14905@lixom.net \
--to=olof@lixom.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=vbarshak@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.