From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: [RFC,PATCH 04/20] svc: xpt_has_wspace Date: Wed, 29 Aug 2007 16:28:23 -0400 Message-ID: <20070829202823.GA4687@fieldses.org> References: <20070820162000.15224.65524.stgit@dell3.ogc.int> <20070820162329.15224.29032.stgit@dell3.ogc.int> <20070829185323.GF23541@fieldses.org> <1188418276.7502.29.camel@trinity.ogc.int> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Neil Brown , nfs@lists.sourceforge.net To: Tom Tucker Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list2-new.sourceforge.net with esmtp (Exim 4.43) id 1IQU9M-0002g0-DL for nfs@lists.sourceforge.net; Wed, 29 Aug 2007 13:28:28 -0700 Received: from mail.fieldses.org ([66.93.2.214] helo=fieldses.org) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1IQU9N-00073u-ND for nfs@lists.sourceforge.net; Wed, 29 Aug 2007 13:28:31 -0700 In-Reply-To: <1188418276.7502.29.camel@trinity.ogc.int> List-Id: "Discussion of NFS under Linux development, interoperability, and testing." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net On Wed, Aug 29, 2007 at 03:11:16PM -0500, Tom Tucker wrote: > This code combines checks for listening endpoints and connected > endpoints in the same function (_has_wspace). Ah, thanks! Sorry, I totally missed the TCP_LISTEN checks before the setting of SK_CONN. > Perhaps I don't understand the nuances fully, but since all the terms in > the condition are AND, they will all be tested and unless there is a > race I'm missing the order doesn't matter. Yes, makes sense to me. > In any event, I think it would be easier to understand if we broken the > tests up into two if-statements with a simple comment for each. Sure. And maybe a block comment someplace explaining the use of SK_CONN? --b. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs