From: Gerrit Renker <gerrit@erg.abdn.ac.uk>
To: dccp@vger.kernel.org
Subject: Re: [PATCH 3/6] DCCP: Introduce CCID3 extensions
Date: Thu, 30 Aug 2007 08:46:31 +0000 [thread overview]
Message-ID: <200708300946.32029@strip-the-willow> (raw)
In-Reply-To: <200708291134.45030.ian.mcdonald@jandi.co.nz>
A style comment - I like the idea of the extensions and can see your point.
To be true, if the code were analysed for extensions then the rfc344bis-00
extensions would probably also count, as well as the erratum for the SYN
RTT sample.
When using a one-bit flag (which automatically behaves like a Boolean type),
such as
/* @ccid3hctx_faster_restart_on: whether Faster Restart is enabled */
/* ... */
u8 ccid3hctx_faster_restart_on:1;
the testing and setting code would be smaller - if a little less elegant.
next prev parent reply other threads:[~2007-08-30 8:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-28 23:34 [PATCH 3/6] DCCP: Introduce CCID3 extensions Ian McDonald
2007-08-30 8:46 ` Gerrit Renker [this message]
2007-09-03 23:02 ` Ian McDonald
2007-09-06 3:05 ` Ian McDonald
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708300946.32029@strip-the-willow \
--to=gerrit@erg.abdn.ac.uk \
--cc=dccp@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.