From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
Cc: Andrew Morton <akpm@linux-foundation.org>,
lkml <linux-kernel@vger.kernel.org>,
netdev@vger.kernel.org
Subject: Re: [PATCH] skge: unbalanced parenthesis fix
Date: Sat, 1 Sep 2007 13:55:39 +0100 [thread overview]
Message-ID: <20070901135539.40557930@oldman> (raw)
In-Reply-To: <200709010810.12798.m.kozlowski@tuxland.pl>
On Sat, 1 Sep 2007 08:10:12 +0200
Mariusz Kozlowski <m.kozlowski@tuxland.pl> wrote:
> Hello,
>
> This patch fixes unbalanced parenthesis.
>
> Signed-off-by: Mariusz Kozlowski <m.kozlowski@tuxland.pl>
>
> drivers/net/skge.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-2.6.23-rc4-mm1-a/drivers/net/skge.h 2007-09-01 07:23:52.000000000 +0200
> +++ linux-2.6.23-rc4-mm1-b/drivers/net/skge.h 2007-09-01 07:37:55.000000000 +0200
> @@ -1351,7 +1351,7 @@ enum {
> PHY_M_PC_EN_DET_PLUS = 3<<8, /* Energy Detect Plus (Mode 2) */
> };
>
> -#define PHY_M_PC_MDI_XMODE(x) ((((u16)(x)<<5) & PHY_M_PC_MDIX_MSK)
> +#define PHY_M_PC_MDI_XMODE(x) (((u16)(x)<<5) & PHY_M_PC_MDIX_MSK)
>
> enum {
> PHY_M_PC_MAN_MDI = 0, /* 00 = Manual MDI configuration */
Since the macro is unused, I would rather just drop it.
next prev parent reply other threads:[~2007-09-01 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-01 6:10 [PATCH] skge: unbalanced parenthesis fix Mariusz Kozlowski
2007-09-01 12:55 ` Stephen Hemminger [this message]
2007-09-01 16:29 ` Mariusz Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070901135539.40557930@oldman \
--to=shemminger@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.