All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Shawn O. Pearce" <spearce@spearce.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: Robin Rosenberg <robin.rosenberg@dewire.com>, git@vger.kernel.org
Subject: Re: [PATCH] Improve bash prompt to detect merge / rebase in progress
Date: Sat, 1 Sep 2007 18:20:36 -0400	[thread overview]
Message-ID: <20070901222036.GH18160@spearce.org> (raw)
In-Reply-To: <7vir6us1ia.fsf@gitster.siamese.dyndns.org>

Junio C Hamano <gitster@pobox.com> wrote:
> Robin Rosenberg <robin.rosenberg@dewire.com> writes:
> >
> > +	local g="$(git rev-parse --git-dir 2>/dev/null)"
> > +	if [ -n "$g" ]; then
> > +		local r
> > +		local b
> > +		if [ -d "$g/../.dotest" ]
> > +		then
> > +			local b="$(git symbolic-ref HEAD 2>/dev/null)"
> > +			r="|REBASEING"
> 
> I might be in the middle of resolving a conflicted "git am".

And there's no way to tell the difference either.  I just spent a
few minutes digging around git-am and git-rebase and realized there
really isn't a way to tell these two user level commands apart as
git-rebase (by default) calls git-am and there's no marker to say
it was started by rebase.

But more than that I have to wonder why git-am still uses .dotest
in the working directory for its state management.  Why don't we
move it into $GIT_DIR like we do for `rebase -m`?

> But I love the idea.  We need to think about cleaning up our
> "state machine" mechanism to make this kind of thing easier to
> do.  We've had a few suggestions on the list in the past but
> they never passed the suggestion/speculation stage.

I love the idea too.  I've actually walked away from a rebase -i and
come back the following day and forgotten that I was in the middle
of a rebase and just thought I was sitting on a detached checkout.
Really confused me for a few minutes when code I was looking for
wasn't found (it was still pending to be applied by rebase -i).

-- 
Shawn.

  reply	other threads:[~2007-09-01 22:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-01 10:22 [PATCH] Improve bash prompt to detect merge / rebase in progress Robin Rosenberg
2007-09-01 18:07 ` Junio C Hamano
2007-09-01 22:20   ` Shawn O. Pearce [this message]
2007-09-02  0:35     ` Johannes Schindelin
2007-09-02  0:44       ` Shawn O. Pearce
2007-09-01 23:02   ` Johannes Schindelin
2007-09-01 23:52   ` Robin Rosenberg
2007-09-02 10:18     ` Johannes Sixt
2007-09-02 10:40       ` Robin Rosenberg
2007-09-04  7:13         ` Shawn O. Pearce
2007-09-30  0:20           ` [PATCH] Improve bash prompt to detect various states like an unfinished merge Robin Rosenberg
2007-10-01  8:15             ` Junio C Hamano
2007-10-01 18:29               ` Robin Rosenberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070901222036.GH18160@spearce.org \
    --to=spearce@spearce.org \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=robin.rosenberg@dewire.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.