From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jesper Juhl Subject: Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host() Date: Sun, 2 Sep 2007 22:03:39 +0200 Message-ID: <200709022203.39922.jesper.juhl@gmail.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: Received: from fk-out-0910.google.com ([209.85.128.190]:16942 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752078AbXIBUG6 convert rfc822-to-8bit (ORCPT ); Sun, 2 Sep 2007 16:06:58 -0400 Received: by fk-out-0910.google.com with SMTP id z23so1181878fkz for ; Sun, 02 Sep 2007 13:06:57 -0700 (PDT) In-Reply-To: Content-Disposition: inline Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Satyam Sharma Cc: Linux Kernel Mailing List , James Bottomley , aacraid@adaptec.com, linux-scsi@vger.kernel.org On Sunday 02 September 2007 22:13:49 Satyam Sharma wrote: >=20 > drivers/scsi/ips.c: In function =E2=80=98ips_register_scsi=E2=80=99: > drivers/scsi/ips.c:6869: > warning: ignoring return value of =E2=80=98scsi_add_host=E2=80=99, de= clared with attribute warn_unused_result >=20 > scsi_add_host() is __must_check, so let's check it's return and clean= up > appropriately on errors. >=20 > Signed-off-by: Satyam Sharma >=20 [snip] Something seems to be wrong either at your end or mine > + IPS_PRINTK(KERN_WARNING, ha->pcidev, "Unable to add SCSI host=C2=A5= n"); This should end with a newline "\n" but I'm seeing "=C2=A5n" ... /Jesper - To unsubscribe from this list: send the line "unsubscribe linux-scsi" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759634AbXIBUHg (ORCPT ); Sun, 2 Sep 2007 16:07:36 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753461AbXIBUHA (ORCPT ); Sun, 2 Sep 2007 16:07:00 -0400 Received: from fk-out-0910.google.com ([209.85.128.189]:16675 "EHLO fk-out-0910.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752334AbXIBUG7 convert rfc822-to-8bit (ORCPT ); Sun, 2 Sep 2007 16:06:59 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:from:to:subject:date:user-agent:cc:references:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:message-id; b=RROsE2hmzZ3PewiqJ4mhxhf9xKhCER7/Gs6GQ2KQcQW7QYaFVUCED79uoWs5aRG7jyWtKSBsBnKzbfpFiDVpaWdtDBRWQEBoU2ZSxG+bMlSQ8UvdCMos+hoRcIuXsHfzYW4AtR+3icln+MKJVbqqrkG+aSww/cQsUS0d7jLK32M= From: Jesper Juhl To: Satyam Sharma Subject: Re: [PATCH -mm] IPS SCSI driver: Check return of scsi_add_host() Date: Sun, 2 Sep 2007 22:03:39 +0200 User-Agent: KMail/1.9.7 Cc: Linux Kernel Mailing List , James Bottomley , aacraid@adaptec.com, linux-scsi@vger.kernel.org References: In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <200709022203.39922.jesper.juhl@gmail.com> Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Sunday 02 September 2007 22:13:49 Satyam Sharma wrote: > > drivers/scsi/ips.c: In function ‘ips_register_scsi’: > drivers/scsi/ips.c:6869: > warning: ignoring return value of ‘scsi_add_host’, declared with attribute warn_unused_result > > scsi_add_host() is __must_check, so let's check it's return and cleanup > appropriately on errors. > > Signed-off-by: Satyam Sharma > [snip] Something seems to be wrong either at your end or mine > + IPS_PRINTK(KERN_WARNING, ha->pcidev, "Unable to add SCSI host¥n"); This should end with a newline "\n" but I'm seeing "¥n" ... /Jesper