From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1IRyVf-0006rf-2o for mharc-grub-devel@gnu.org; Sun, 02 Sep 2007 19:05:39 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IRyVd-0006om-4a for grub-devel@gnu.org; Sun, 02 Sep 2007 19:05:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IRyVb-0006lt-DF for grub-devel@gnu.org; Sun, 02 Sep 2007 19:05:36 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IRyVb-0006lf-6N for grub-devel@gnu.org; Sun, 02 Sep 2007 19:05:35 -0400 Received: from aybabtu.com ([69.60.117.155]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IRyVa-0006h7-PK for grub-devel@gnu.org; Sun, 02 Sep 2007 19:05:34 -0400 Received: from [192.168.10.6] (helo=thorin) by aybabtu.com with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.63) (envelope-from ) id 1IRyVY-0004Jf-Mr for grub-devel@gnu.org; Mon, 03 Sep 2007 01:05:33 +0200 Received: from rmh by thorin with local (Exim 4.63) (envelope-from ) id 1IRyVG-00065t-Ip for grub-devel@gnu.org; Mon, 03 Sep 2007 01:05:14 +0200 Date: Mon, 3 Sep 2007 01:05:14 +0200 From: Robert Millan To: The development of GRUB 2 Message-ID: <20070902230514.GA13963@thorin> References: <20070902141736.af8d1d50.dn.tlp@gmx.net> <20070902160538.GA21432@thorin> <20070902192526.2ba6a17d.dn.tlp@gmx.net> <20070902194110.GA8231@thorin> <20070902225345.81fa084c.dn.tlp@gmx.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20070902225345.81fa084c.dn.tlp@gmx.net> Organization: free as in freedom X-Message-Flag: Microsoft discourages use of Outlook. X-Debbugs-No-Ack: true User-Agent: Mutt/1.5.13 (2006-08-11) X-Detected-Kernel: Genre and OS details not recognized. Subject: Re: Strong Crypto Support for GRUB2 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 02 Sep 2007 23:05:37 -0000 On Sun, Sep 02, 2007 at 10:53:45PM +0200, Simon Peter wrote: > > > +#ifndef GET_UINT32_BE > > > +#define GET_UINT32_BE(n,b,i) \ > > > +{ \ > > > + (n) = ( (uint32) (b)[(i) ] << 24 ) \ > > > + | ( (uint32) (b)[(i) + 1] << 16 ) \ > > > + | ( (uint32) (b)[(i) + 2] << 8 ) \ > > > + | ( (uint32) (b)[(i) + 3] ); \ > > > +} > > Doesn't follow GCS indentation style in a number of places. I would > > suggest using the indent(1) tool on it. > > Any specific options that I shall use? I use it without options. But please note that I'm not the guy in charge here, just providing advice on what I think the maintainers will like to see (since Marco and Okuji are often busy). > > > +GRUB_MOD_INIT(crypto) > > > +{ > > > + (void)mod; /* To stop warning. */ > > > + grub_crypto_cipher_register(&grub_cipher_none); > > > + grub_crypto_cipher_register(&grub_hash_none); > > > +} > > Which warning was that? > > Actually, I copied that line verbatim from hello.c, the GRUB hello > world module. :) It seems that warning is long gone. Oh. It seems that lot of modules have this, and there are no gcc warnings when removing them. I would go and remove them all, unless we're missing something; anyone knows about them? > > 3) doesn't look GPL-compatible. As for 1), note the author is > > claiming ownership of any patents that might be covered by this > > code. GPL compatibility aside, I'm not sure what the consequences of > > accepting the license would be (could it lead to someone > > acknowledging K.U.Leuven as the owner of their own patents?), but it > > looks dangerous. > > Interesting, as RIPEMD is known to be one of the most open and > unencumbered hash functions (see http://en.wikipedia.org/wiki/RIPEMD). > There are no patents covering the code. :) Ah, that is good (although on patents you can never be sure if one exists). My point is that this particular wording is a bit slippery, and I don't think it means what the author intended (IANAL, etc). > > > +enum grub_cipher_type > > > + { > > > + GRUB_CIPHER_TYPE_NONE = 0, > > > + GRUB_CIPHER_TYPE_CIPHER = 1, > > > + GRUB_CIPHER_TYPE_HASH = 2 > > > + }; > > Wasn't the point of using enum to avoid hardcoding these numbers? :-) > > Woops. I thought you guys were doing the same and that's why I did it. > I reverted that (leaving NONE = 0 intact). Oh, didn't notice that. Then I suppose you're better off keeping the numbers. > I'm going to post another patch with your comments implemented, after I > have your reply (I need to know what to pass to indent(1)). Don't forget the ChangeLog entry ;-) -- Robert Millan I know my rights; I want my phone call! What use is a phone call, if you are unable to speak? (as seen on /.)