From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Arnd Bergmann To: Geoff Levand Subject: Re: [patch 1/2] PS3: Clear SPU Class 0 interrupts in handler Date: Wed, 5 Sep 2007 00:50:30 +0200 References: <46DD4777.8050402@am.sony.com> In-Reply-To: <46DD4777.8050402@am.sony.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Message-Id: <200709050050.30968.arnd@arndb.de> Cc: "Noguchi, Masato" , "linuxppc-dev@ozlabs.org" , Paul Mackerras , Jeremy Kerr List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tuesday 04 September 2007, Geoff Levand wrote: > From: Masato Noguchi >=20 > Fix a bug that causes the PS3 to hang on the SPU Class 0 interrupt. >=20 > The Cell BE Architecture spec states that the SPU MFC Class 0 interrupt > is delivered as a pulse. =C2=A0The current spu interrupt handler assumes = this > behavior and does not clear the interrupt status. >=20 > The PS3 hypervisor visualizes all SPU interrupts as level, and on return > from the interrupt handler the hypervisor will deliver a new virtual > interrupt for any unmasked interrupts which for which the status has not > been cleared. =C2=A0This fix clears the interrupt status in the interrupt > handler. Right, we have this one in the sdk3.0/2.6.22-arnd2 kernel since I pulled in all of the ps3-linux tree, so it was already part of our testing, and the explanation makes sense, so we should certainly have it upstream. Jeremy, please add this to your patch queue. > Signed-off-by: Masato Noguchi > Signed-off-by: Geoff Levand Acked-by: Arnd Bergmann