From: Pavel Roskin <proski@gnu.org>
To: Catalin Marinas <catalin.marinas@gmail.com>,
kha@treskal.com, git@vger.kernel.org
Subject: [PATCH] git.__remotes_from_dir() should only return lists
Date: Wed, 05 Sep 2007 12:57:22 -0400 [thread overview]
Message-ID: <20070905165722.17744.56584.stgit@dv.roinet.com> (raw)
If there are no remotes, return empty list, not None. The later doesn't
work with builtin set().
This fixes t1001-branch-rename.sh
Signed-off-by: Pavel Roskin <proski@gnu.org>
---
stgit/git.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/stgit/git.py b/stgit/git.py
index 4b4c626..f847cce 100644
--- a/stgit/git.py
+++ b/stgit/git.py
@@ -953,7 +953,7 @@ def __remotes_from_dir(dir):
if os.path.exists(d):
return os.listdir(d)
else:
- return None
+ return []
def remotes_list():
"""Return the list of remotes in the repository
next reply other threads:[~2007-09-05 16:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-05 16:57 Pavel Roskin [this message]
2007-09-06 11:26 ` [PATCH] git.__remotes_from_dir() should only return lists Karl Hasselström
2007-09-06 12:38 ` Pavel Roskin
2007-09-06 14:26 ` Karl Hasselström
2007-09-06 23:11 ` Karl Hasselström
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070905165722.17744.56584.stgit@dv.roinet.com \
--to=proski@gnu.org \
--cc=catalin.marinas@gmail.com \
--cc=git@vger.kernel.org \
--cc=kha@treskal.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.