From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: [PATCH] PNFS: filelayout_commit corrupts RPC all_tasks Date: Wed, 5 Sep 2007 14:17:58 -0400 Message-ID: <20070905181758.GD13314@fieldses.org> References: <1189015398.22424.54.camel@trinity.ogc.int> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: Linux NFS Mailing List To: Tom Tucker Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list2-new.sourceforge.net with esmtp (Exim 4.43) id 1ISzS1-0003GE-EF for nfs@lists.sourceforge.net; Wed, 05 Sep 2007 11:18:05 -0700 Received: from mail.fieldses.org ([66.93.2.214] helo=fieldses.org) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1ISzS4-0000Hp-Jc for nfs@lists.sourceforge.net; Wed, 05 Sep 2007 11:18:10 -0700 In-Reply-To: <1189015398.22424.54.camel@trinity.ogc.int> List-Id: "Discussion of NFS under Linux development, interoperability, and testing." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net On Wed, Sep 05, 2007 at 01:03:18PM -0500, Tom Tucker wrote: > The filelayout_commit function incorrectly releases the nfs_write_data > pointed to by 'data'. Probably we should continue to keep discussion of the pnfs implementation on pnfs@linux-nfs.org for now. --b. Basically, the task contained in the nfs_write_data > structure has already been initialized (rpc_init_task) up in the generic NFS > commit logic. Calling nfs4_commit_free frees the memory, but doesn't remove > the task from the RPC all_tasks list. With debug turned on, the task list > is corrupted immediately by poison_obj; without debug, a freed task is > sitting on the all_tasks list and will eventually be corrupted when the > memory is reused. > > Signed-off-by: Tom Tucker > --- > > fs/nfs/nfs4filelayout.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/fs/nfs/nfs4filelayout.c b/fs/nfs/nfs4filelayout.c > index 86ced63..1a32925 100644 > --- a/fs/nfs/nfs4filelayout.c > +++ b/fs/nfs/nfs4filelayout.c > @@ -583,7 +583,7 @@ filelayout_commit(struct pnfs_layout_typ > } > > /* Release original commit data since it is not used */ > - nfs4_commit_free(data); > + rpc_release_task(&data->task); > return 0; > > out_bad: > > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a browser. > Download your FREE copy of Splunk now >> http://get.splunk.com/ > _______________________________________________ > NFS maillist - NFS@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/nfs ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs