Re: linux-2.6.23-rc4 ppc build failure

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Friday 31 August 2007, Tony Breeds wrote:
> On Thu, Aug 30, 2007 at 02:56:50PM -0700, Bret Towe wrote:
> > On 8/29/07, Bret Towe <magnade@gmail.com> wrote:
> > > while trying to build a fresh kernel for my mini after upgrading from gutsy
> > > (and forgetting to save my .config) I hit the below build error
> > > 2.6.23-rc3 I did work under feisty but that is with a different .config
> > > so not sure if that makes any difference or not
> > > I've not bisected cause it takes so long on this computer...
> > > attached is the config I'm working off now
> 
> So how did you generate the new .config?  Did you start with a defconfig
> of some sort and then alter to personal taste?

The problem might be related with switching CONFIG_IDE to use menuconfig.

> I ask because if we have other users our there that have working system
> with BLK_DEV_IDE=m it'd be nice to have make oldconfig fix them.  If
> it's just a matter of not letting people get into that state then
> something like the patch below will probably help.

Unlikely that there are working BLK_DEV_IDE=m setups - these missing
symbols (pmac_ide_get_base and friends) have never been exported (IIRC).

> Ensure that BLK_DEV_IDE is built-in befoer allowing BLK_DEV_IDE_PMAC to
> be selected.
> 
> Signed-off-by: Tony Breeds <tony@bakeyournoodle.com>

applied with s/befoer/before/ as spotted by Bret

> ---
> 
>  drivers/ide/Kconfig |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig
> index e049f65..e55be26 100644
> --- a/drivers/ide/Kconfig
> +++ b/drivers/ide/Kconfig
> @@ -780,7 +780,7 @@ endif
>  
>  config BLK_DEV_IDE_PMAC
>  	bool "Builtin PowerMac IDE support"
> -	depends on PPC_PMAC && IDE=y
> +	depends on PPC_PMAC && IDE=y && BLK_DEV_IDE=y
>  	help
>  	  This driver provides support for the built-in IDE controller on
>  	  most of the recent Apple Power Macintoshes and PowerBooks.