From: Mike Hommey <mh@glandium.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: Significant performance waste in git-svn and friends
Date: Thu, 6 Sep 2007 07:52:11 +0200 [thread overview]
Message-ID: <20070906055211.GC5741@glandium.org> (raw)
In-Reply-To: <7vd4wwj16d.fsf@gitster.siamese.dyndns.org>
On Wed, Sep 05, 2007 at 01:40:42PM -0700, Junio C Hamano <gitster@pobox.com> wrote:
> Mike Hommey <mh@glandium.org> writes:
>
> > The same things obviously apply to git-cvsimport and other scripts
> > calling git-hash-object a lot.
>
> I *obviously* hate this patch, as it makes this Porcelain
> command to be aware of the internal representation too much.
The patch was not supposed to be applied. I said it was lame ;)
It was more of a proof of concept.
Anyways, thinking a bit more about it, I was wondering if it wouldn't be
a good idea to have Git.pm have a "native" implementation (by native I
mean a .so module) for low-level plumbing tools such as hash-object,
cat-file and such.
Obviously, reinventing the wheel is not good, so this native
implementation would be using a "git library" API, such as what has
been done under SoC (though I don't know if this API exposes low-level
plumbing functions)
> I wonder if letting fast-import handle the object creation is an
> option, though.
It could, probably. The reason I didn't use it is that it was way
quicker to hack a 10 lines patch to create the blobs by hand than it
would have been to fork a fast-import object at the correct place during
git-svn initialization and piping to it at the appropriate times.
My goal was only to check how faster this would make it not to fork a
git-hash-object per blob.
Mike
next prev parent reply other threads:[~2007-09-06 5:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-05 18:47 Significant performance waste in git-svn and friends Mike Hommey
2007-09-05 20:40 ` Junio C Hamano
2007-09-05 21:19 ` David Kastrup
2007-09-06 1:07 ` Patrick Doyle
2007-09-06 2:19 ` Shawn O. Pearce
2007-09-06 2:16 ` Shawn O. Pearce
2007-09-06 5:52 ` Mike Hommey [this message]
2007-09-06 7:04 ` Eric Wong
2007-09-07 4:55 ` Shawn O. Pearce
2007-09-07 6:28 ` Steven Grimm
2007-09-07 5:41 ` Mike Hommey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070906055211.GC5741@glandium.org \
--to=mh@glandium.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.