From: Nick Piggin <npiggin@suse.de>
To: Oleg Verych <olecom@flower.upol.cz>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Paul McKenney <paulmck@us.ibm.com>
Subject: Re: Fast path efficiency (Re: [rfc][patch] dynamic data structure switching)
Date: Thu, 6 Sep 2007 09:14:28 +0200 [thread overview]
Message-ID: <20070906071428.GA24721@wotan.suse.de> (raw)
In-Reply-To: <E1IT3wK-0006Bh-22@flower>
On Thu, Sep 06, 2007 at 01:05:40AM +0200, Oleg Verych wrote:
> * Sun, 2 Sep 2007 20:36:19 +0200
> >
>
> I see, that in many places all pre-checks are done in negative form
> with resulting return or jump out. In this case, if function was called,
> what likely() path is?
>
> > +static void resize_pid_hash(void)
> > +{
> > + unsigned int old_shift, new_shift;
> > +
> > + if (system_state != SYSTEM_RUNNING)
> > + return;
> > +
> > + old_shift = cur_pid_hash->shift;
> > + new_shift = ilog2(nr_pids * 2 - 1);
> > + if (new_shift == old_shift)
> > + return;
> > +
> > + if (!mutex_trylock(&dyn_pidhash.resize_mutex))
> > + return;
>
> that one or this?
>
> ==
> if (system_state == SYSTEM_RUNNING) {
> old_shift = cur_pid_hash->shift;
> new_shift = ilog2(nr_pids * 2 - 1);
> if (new_shift != old_shift && mutex_trylock(&dyn_pidhash.resize_mutex)) {
> ==
> > + old_shift = cur_pid_hash->shift;
> > + new_shift = ilog2(nr_pids * 2 - 1);
>
> /* hope this repetition is needed by design */
>
> ...
>
> > + mutex_unlock(&dyn_pidhash.resize_mutex);
> }
>
> What is more efficient in general sense,
> as opposed to s,3,2,1,0 Optimized?
I'm not too sure, but I'd guess that most of the time the compiler will
be able to figure out they are the same.
resize_pid_hash() fortunately isn't a fastpath anyway -- it calls
dyn_data_replace which ends up calling synchronize_rcu() 3 times,
each of which is likely to take a long time!
next prev parent reply other threads:[~2007-09-06 7:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-02 18:27 [rfc][patch] dynamic data structure switching Nick Piggin
2007-09-02 18:36 ` Nick Piggin
2007-09-05 23:05 ` Fast path efficiency (Re: [rfc][patch] dynamic data structure switching) Oleg Verych
2007-09-06 7:14 ` Nick Piggin [this message]
2007-09-06 11:35 ` Andi Kleen
2007-09-10 11:55 ` [rfc][patch] dynamic data structure switching Peter Zijlstra
2007-09-10 13:39 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070906071428.GA24721@wotan.suse.de \
--to=npiggin@suse.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=olecom@flower.upol.cz \
--cc=paulmck@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.