From: "Dmitry V. Levin" <ldv@altlinux.org>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH 1/3] git-gui/Makefile: Replace libdir with gitgui_libdir
Date: Thu, 6 Sep 2007 14:00:12 +0400 [thread overview]
Message-ID: <20070906100012.GC6665@basalt.office.altlinux.org> (raw)
In-Reply-To: <20070906023227.GH18160@spearce.org>
[-- Attachment #1: Type: text/plain, Size: 1288 bytes --]
On Wed, Sep 05, 2007 at 10:32:27PM -0400, Shawn O. Pearce wrote:
> "Dmitry V. Levin" <ldv@altlinux.org> wrote:
> > On GNU/Linux, libdir is used to mean "/usr/lib or /usr/lib64"
> > depending on architecture. Different libdir meaning breaks
> > idiomatic expressions like rpm specfile "make libdir=%_libdir".
> >
> > Signed-off-by: Dmitry V. Levin <ldv@altlinux.org>
> > ---
> > git-gui/Makefile | 16 ++++++++--------
> > 1 files changed, 8 insertions(+), 8 deletions(-)
>
> Although I could apply this with `am -3` I'm NACK'ing this right
> now because...
[...]
> git-gui is its own project with its own Makefile. Junio includes
> it in git.git to help widen its audience, and because it is quite
> portable and easy for him to include. In the future git-gui will
> become a proper subproject of git.git.
The idea is that git-gui's libdir is not a traditional arch-dependent
libdir's subdirectory, but rather arch-independent datadir's subdirectory.
That is, I see no reason to call it libdir even in standalone project.
> If you want to define libdir in git's toplevel Makefile *and*
> that definition is being exported down into git-gui's Makefile
Yes, that was my first motivation, but the issue appears to be a bit more
complex.
--
ldv
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2007-09-06 10:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-05 23:21 [PATCH 1/3] git-gui/Makefile: Replace libdir with gitgui_libdir Dmitry V. Levin
2007-09-06 2:32 ` Shawn O. Pearce
2007-09-06 10:00 ` Dmitry V. Levin [this message]
2007-09-07 5:01 ` Shawn O. Pearce
2007-09-07 12:44 ` Dmitry V. Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070906100012.GC6665@basalt.office.altlinux.org \
--to=ldv@altlinux.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.