All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Al Viro <viro@ftp.linux.org.uk>, Jeff Garzik <jeff@garzik.org>
Cc: netdev@vger.kernel.org
Subject: dgrs: sparse warnings
Date: Thu, 6 Sep 2007 13:55:47 +0100	[thread overview]
Message-ID: <20070906135547.13bb3326@oldman> (raw)

The dgrs driver is crap and assumes direct access to PCI iomem.

  CHECK   drivers/net/dgrs.c
drivers/net/dgrs.c:314:20: warning: cast removes address space of expression
drivers/net/dgrs.c:330:12: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:330:12:    expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:330:12:    got void *<noident>
drivers/net/dgrs.c:1003:14: warning: incorrect type in assignment (different address spaces)
drivers/net/dgrs.c:1003:14:    expected char *[usertype] vmem
drivers/net/dgrs.c:1003:14:    got void [noderef] <asn:2>*
drivers/net/dgrs.c:1023:17: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:1023:17:    expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:1023:17:    got char *[usertype] vmem
drivers/net/dgrs.c:1052:16: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:1052:16:    expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:1052:16:    got char *[usertype] vmem
drivers/net/dgrs.c:1106:16: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:1106:16:    expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:1106:16:    got char *[usertype] vmem
drivers/net/dgrs.c:1369:15: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:1369:15:    expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:1369:15:    got char *[usertype] vmem
drivers/net/dgrs.c:1371:12: warning: incorrect type in argument 1 (different address spaces)
drivers/net/dgrs.c:1371:12:    expected void volatile [noderef] <asn:2>*addr
drivers/net/dgrs.c:1371:12:    got unsigned char [usertype] *<noident>

Perhaps we should just mark it as BROKEN in Kconfig

             reply	other threads:[~2007-09-06 12:55 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-06 12:55 Stephen Hemminger [this message]
2007-09-06 13:30 ` dgrs: sparse warnings maximilian attems
2007-09-06 13:50   ` [patch] dgrs removal maximilian attems
2007-09-06 14:16     ` maximilian attems
2007-09-06 14:24       ` maximilian attems

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070906135547.13bb3326@oldman \
    --to=shemminger@linux-foundation.org \
    --cc=jeff@garzik.org \
    --cc=netdev@vger.kernel.org \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.