All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Lachlan McIlroy <lachlan@sgi.com>
Cc: xfs-dev <xfs-dev@sgi.com>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] ensure file size is logged on synchronous writes
Date: Mon, 10 Sep 2007 16:07:45 +0100	[thread overview]
Message-ID: <20070910150745.GA16595@infradead.org> (raw)
In-Reply-To: <46DB7A60.4050203@sgi.com>

On Mon, Sep 03, 2007 at 01:07:12PM +1000, Lachlan McIlroy wrote:
> Synchronous writes currently log inode changes before syncing
> pages to disk.  Since the file size is updated on I/O completion
> we wont be writing out the updated file size and if we crash the
> file will have the wrong size.  This change moves the logging
> after the syncing of the pages to ensure we log the correct file
> size.

Looks good to me.

      reply	other threads:[~2007-09-10 15:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-03  3:07 [PATCH] ensure file size is logged on synchronous writes Lachlan McIlroy
2007-09-10 15:07 ` Christoph Hellwig [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070910150745.GA16595@infradead.org \
    --to=hch@infradead.org \
    --cc=lachlan@sgi.com \
    --cc=xfs-dev@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.