From: Olof Johansson <olof@lixom.net>
To: Nathan Lynch <ntl@pobox.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [POWERPC] pasemi: Move pasemi_idle_init() to late_initcall()
Date: Mon, 10 Sep 2007 11:00:52 -0500 [thread overview]
Message-ID: <20070910160052.GA23616@lixom.net> (raw)
In-Reply-To: <20070910154443.GK32388@localdomain>
On Mon, Sep 10, 2007 at 10:44:43AM -0500, Nathan Lynch wrote:
> Olof Johansson wrote:
> > commit 6a30bd1e2160e921a8fb051b472dfaf068f4f386
> > Author: Olof Johansson <olof@lixom.net>
> > Date: Tue Sep 4 21:53:30 2007 -0500
> >
> > [POWERPC] pasemi: Move pasemi_idle_init() to late_initcall()
> >
> > Move pasemi_idle_init() to be a late_initcall instead of being called from
> > setup_arch(). This way the cpufreq driver has a chance to initialize and
> > save away the boot time astate before we go to idle for the first time.
>
> The patch looks fine, but while I was reviewing this I noticed that
> the pasemi cpufreq code is bool in Kconfig, but it has stuff like
> module_init() etc in it. It's not hurting anything, but it did
> temporarily make me wonder "what happens if the cpufreq driver is
> modular"?
Good point. I actually kept it from being modular for the very reason
that it's needed in the idle loop to restore the cpu frequency when
coming out of power savings modes.
The whole idle/cpufreq dependencies should be overhauled at some point,
to avoid this, or at least allow the cpufreq driver to be a module
(and make idle default to spin when it's not loaded).
-Olof
prev parent reply other threads:[~2007-09-10 16:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-05 2:07 Please pull from 'for-2.6.24' branch Olof Johansson
2007-09-05 2:08 ` [POWERPC] pasemi: add pasemi_pci_getcfgaddr() Olof Johansson
2007-09-05 2:08 ` [POWERPC] pasemi: Add workaround for erratum 5945 Olof Johansson
2007-09-05 2:09 ` [POWERPC] pasemi: Export more SPRs to sysfs when CONFIG_DEBUG_KERNEL=y Olof Johansson
2007-09-05 2:09 ` [POWERPC] pasemi: Print more information at machine check Olof Johansson
2007-09-05 2:09 ` [POWERPC] pasemi: Move pasemi_idle_init() to late_initcall() Olof Johansson
2007-09-10 15:44 ` Nathan Lynch
2007-09-10 16:00 ` Olof Johansson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070910160052.GA23616@lixom.net \
--to=olof@lixom.net \
--cc=linuxppc-dev@ozlabs.org \
--cc=ntl@pobox.com \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.