From: Ingo Molnar <mingo@elte.hu>
To: arnd@arndb.de
Cc: linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
David Miller <davem@davemloft.net>
Subject: Re: [patch 1/3] futex_compat: fix list traversal bugs
Date: Mon, 10 Sep 2007 21:34:53 +0200 [thread overview]
Message-ID: <20070910193453.GA4964@elte.hu> (raw)
In-Reply-To: <20070910191648.561256021@arndb.de>
* arnd@arndb.de <arnd@arndb.de> wrote:
> The futex list traversal on the compat side appears to have a bug.
>
> It's loop termination condition compares:
>
> while (compat_ptr(uentry) != &head->list)
>
> But that can't be right because "uentry" has the special "pi"
> indicator bit still potentially set at bit 0. This is cleared by
> fetch_robust_entry() into the "entry" return value.
hm. I remember having tested this - not well enough i guess :-/
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
next prev parent reply other threads:[~2007-09-10 19:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-10 19:13 [patch 0/3] futex_compat fixes arnd
2007-09-10 19:13 ` [patch 1/3] futex_compat: fix list traversal bugs arnd
2007-09-10 19:34 ` Ingo Molnar [this message]
2007-09-10 19:13 ` [patch 2/3] futex_compat: simplify pointer magic arnd
2007-09-10 19:35 ` Ingo Molnar
2007-09-10 19:13 ` [patch 3/3] futex_compat: update to match native version arnd
2007-09-10 19:35 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070910193453.GA4964@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.