All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Christoph Lameter <clameter@sgi.com>
Cc: "Zhang, Yanmin" <yanmin_zhang@linux.intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	mingo@elte.hu, Mel Gorman <mel@skynet.ie>,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: tbench regression - Why process scheduler has impact on tbench and why small per-cpu slab (SLUB) cache creates the scenario?
Date: Tue, 11 Sep 2007 01:17:57 +1000	[thread overview]
Message-ID: <200709110117.57387.nickpiggin@yahoo.com.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0709101201140.24491@schroedinger.engr.sgi.com>

On Tuesday 11 September 2007 05:07, Christoph Lameter wrote:
> On Mon, 10 Sep 2007, Nick Piggin wrote:
> > OK, so after isolating the scheduler, then SLUB should be as fast as SLAB
> > at the same allocation size. That's basically what we need to do before
> > we can replace SLAB with it, I think?
>
> The regression is due to the limited number of objects in the per cpu
> "queue" in SLUB for 4k objects. With the .23 code this is one or two
> (order 1 slab). So we have to call into the page allocator frequently and
> do it for order 1 pages which requires the zone locks. Urgh.

The impression I got at vm meeting was that SLUB was good to go :(


> I think the regression is best addressed by the page allocator pass
> through patch in mm which makes the page allocator handle these objects.
> They are single pages so the pcp lists are in use which provide much
> larger queues than SLUB/SLAB.
>
> IMHO >=4k objects should be handled by the page allocator. From the
> numbers I have seen there is then still a 1% regression left. If
> that is still the case after we have fixed the scheduler then maybe
> we need to slim down the page allocator fast path.

It is trivial to test SLUB vs SLAB independently of the scheduler change.
And actually, a scheduler regression here might just never be fixed,
because it is likely to be a higher level thing where the scheduling just
happens not to interact with tbench so well (and either it would be
impossible to find out why, or no point tuning the scheduler for such a
case).

But slab allocations don't really control the macro behaviour of a
benchmark like that so much. So don't wait until something happens
with the scheduler, fix it now.

Yay, looks like we'll get yet more logic in the VM to polish the proverbial
turd that is higher order allocations :P

  reply	other threads:[~2007-09-11  6:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-05  0:46 tbench regression - Why process scheduler has impact on tbench and why small per-cpu slab (SLUB) cache creates the scenario? Zhang, Yanmin
2007-09-05  3:59 ` Christoph Lameter
2007-09-05  5:22   ` Zhang, Yanmin
2007-09-05  6:58     ` Christoph Lameter
2007-09-05  9:13       ` Zhang, Yanmin
2007-09-05 10:45         ` Christoph Lameter
2007-09-06  0:52           ` Zhang, Yanmin
2007-09-05  7:07     ` Christoph Lameter
2007-09-08  8:08       ` Nick Piggin
2007-09-10  0:56         ` Zhang, Yanmin
2007-09-09 22:10           ` Nick Piggin
2007-09-10 19:07             ` Christoph Lameter
2007-09-10 15:17               ` Nick Piggin [this message]
2007-09-11 20:19                 ` Christoph Lameter
2007-09-11  4:59                   ` Nick Piggin
2007-09-13  6:04                   ` Siddha, Suresh B
2007-09-13 18:03                     ` Christoph Lameter
2007-09-14 19:15                       ` Siddha, Suresh B
2007-09-14 19:51                         ` Christoph Lameter
2007-09-19  2:17                           ` Siddha, Suresh B
2007-09-20 17:53                             ` Christoph Lameter

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200709110117.57387.nickpiggin@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=akpm@linux-foundation.org \
    --cc=clameter@sgi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mel@skynet.ie \
    --cc=mingo@elte.hu \
    --cc=torvalds@linux-foundation.org \
    --cc=yanmin_zhang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.