All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jose R. Santos" <jrs@us.ibm.com>
To: "Andreas Dilger" <adilger@clusterfs.com>
Cc: "ext4 development" <linux-ext4@vger.kernel.org>
Subject: Re: [PATCH] FLEX_BG Kernel support.
Date: Tue, 11 Sep 2007 07:27:17 -0500	[thread overview]
Message-ID: <20070911072717.1b5fc7a8@gara> (raw)
In-Reply-To: <2aa04ba80709102304i1b054fbbo1d0d4081a86c1580@mail.gmail.com>

On Tue, 11 Sep 2007 00:04:43 -0600
"Andreas Dilger" <adilger@clusterfs.com> wrote:

> On 9/10/07, Jose R. Santos <jrs@us.ibm.com> wrote:
> > @@ -1254,7 +1254,8 @@ static int ext4_check_descriptors (struct super_block * sb)
> >
> >         for (i = 0; i < sbi->s_groups_count; i++)
> >         {
> > -               if (i == sbi->s_groups_count - 1)
> > +               if (i == sbi->s_groups_count - 1 || EXT4_HAS_INCOMPAT_FEATURE(sb,
> > +                                       EXT4_FEATURE_INCOMPAT_FLEX_BG))
> >                         last_block = ext4_blocks_count(sbi->s_es) - 1;
> 
> No need to check this featyre for every  group, once at the beginning
> of the function is enough.
> 

Do you mean something like the original patch?
http://lists.openwall.net/linux-ext4/2007/07/12/20

Wouldn't we need to check all the descriptor for corruption if checksum
is not enable on the filesystem?

-JRS

  reply	other threads:[~2007-09-11 12:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-10 21:22 [PATCH] FLEX_BG Kernel support Jose R. Santos
2007-09-11  6:04 ` Andreas Dilger
2007-09-11 12:27   ` Jose R. Santos [this message]
2007-09-11 23:21     ` Andreas Dilger
2007-09-12  0:04       ` Jose R. Santos

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070911072717.1b5fc7a8@gara \
    --to=jrs@us.ibm.com \
    --cc=adilger@clusterfs.com \
    --cc=linux-ext4@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.