From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Tue, 11 Sep 2007 22:49:52 +0200 Subject: [U-Boot-Users] [PATCH7] microblaze - ROMFS adapt files In-Reply-To: Your message of "Tue, 11 Sep 2007 09:14:26 MDT." Message-ID: <20070911204952.183BA247DA@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message you wrote: > On 8/30/07, Michal Simek wrote: > > DESC: ROMFS support files and sorted names in Makefiles > > > > Signed-off-by: Michal Simek > > > > Note; I think that we can start process with redesigning all FS support > > I'm still not really fond of this approach. Repurposing CONFIG_JFFS2 > to add more and more filesystems is not a good approach. I don't > recommend merging this as is. Agreed. In any case it's not a bug fix and thus will not go into 1.3.0. > Ideally, the whole filesystem handling should be reworked into a > single API, but I understand that it's a non-trivial amount of work. > However, at the very least, ROMFS should be configured with a separate > CONFIG_xxx macro. Agreed, too. > > - /* check partition type for cramfs */ > > - fsname = (cramfs_check(part) ? "CRAMFS" : "JFFS2"); > > + /* check partition type for JFFS2, cramfs, romfs */ > > + if (cramfs_check(part)) { > > + fsname = "CRAMFS"; > > + } else if (romfs_check(part)) { > > + fsname = "ROMFS"; > > + } else { > > + fsname = "JFFS2"; > > + } > > This will get unwieldy in a real hurry. This should probably be > reworked into a table of filesystem handlers which binds all the > driver callbacks. Indeed. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de The heart is not a logical organ. -- Dr. Janet Wallace, "The Deadly Years", stardate 3479.4