From: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks (take 2)
Date: Tue, 11 Sep 2007 22:52:02 +0200 [thread overview]
Message-ID: <200709112252.02576.bzolnier@gmail.com> (raw)
In-Reply-To: <46E2900D.5010004@ru.mvista.com>
Hi,
On Saturday 08 September 2007, Sergei Shtylyov wrote:
> Once I quothed:
>
> > Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at it,
> > make the udma_filter() method calls take precedence over using the mode masks.
>
> This one not looking to pretty -- I've geve some thought on how to
> beautify all these switch fallthoughs but haven't got something much better
> then uour original approach (AKA Occam's razor :-).
Care to recast the patch to contain only udma_filter() part?
BTW ide_rate_filter() still lacks respecting PIO limits of the device
(Occam's razor doesn't apply to "PIO side" of ide_rate_filter() ;-)
Thanks,
Bart
next prev parent reply other threads:[~2007-09-11 21:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-02 19:44 [PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks (take 2) Sergei Shtylyov
2007-09-03 18:50 ` Bartlomiej Zolnierkiewicz
2007-09-08 12:05 ` Sergei Shtylyov
2007-09-11 20:52 ` Bartlomiej Zolnierkiewicz [this message]
2007-09-24 12:44 ` Sergei Shtylyov
2007-09-24 18:48 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709112252.02576.bzolnier@gmail.com \
--to=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.