From: Paul Mundt <lethal@linux-sh.org>
To: Michal Januszewski <spock@gentoo.org>
Cc: Paulo Marques <pmarques@grupopie.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm] uvesafb: Don't access VGA registers directly when running on non-x86
Date: Wed, 12 Sep 2007 09:44:37 +0900 [thread overview]
Message-ID: <20070912004437.GA26720@linux-sh.org> (raw)
In-Reply-To: <20070911230959.GA16406@spock.one.pl>
On Wed, Sep 12, 2007 at 01:09:59AM +0200, Michal Januszewski wrote:
> The VGA registers are only available at their legacy IO locations on x86.
> Don't try to access them when running on other arches.
>
> Note that the code accessing them directly is just an optimization (limits
> slow BIOS function calls). We don't lose any functionality by using
> BIOS calls instead of it on non-x86.
>
If you do that, then you also have to #ifdef CONFIG_X86 around
video/vga.h, as that drags in asm/vga.h, which does not exist on all
platforms. I have little interest in adding a stub vga.h on my
architectures to support a driver that in practice works on nothing but
x86.
next prev parent reply other threads:[~2007-09-12 0:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 8:17 [PATCH -mm] video: uvesafb: Add X86 dependency Paul Mundt
2007-09-11 11:41 ` Paulo Marques
2007-09-11 11:53 ` Paul Mundt
2007-09-11 12:19 ` Paulo Marques
2007-09-11 12:31 ` Paul Mundt
2007-09-11 22:59 ` Michal Januszewski
2007-09-11 23:09 ` [PATCH -mm] uvesafb: Don't access VGA registers directly when running on non-x86 Michal Januszewski
2007-09-12 0:44 ` Paul Mundt [this message]
2007-09-12 19:41 ` Michal Januszewski
2007-09-13 1:43 ` Paul Mundt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070912004437.GA26720@linux-sh.org \
--to=lethal@linux-sh.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pmarques@grupopie.com \
--cc=spock@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.