From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Denk Date: Wed, 12 Sep 2007 21:46:56 +0200 Subject: [U-Boot-Users] [PATCH9] microblaze EMAC support In-Reply-To: Your message of "Tue, 11 Sep 2007 17:46:08 +0200." <2111.4027-22284-1365301341-1189525568@seznam.cz> Message-ID: <20070912194656.BF38A247D2@gemini.denx.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de In message <2111.4027-22284-1365301341-1189525568@seznam.cz> you wrote: > > DESC: Xilinx Emac support > > > > Signed-off-by: Michal Simek > > > Another good looking driver. All my comments are minor ones. > :-) > > >This isn't used anywhere but xilinx_emac.c. I'd just roll them into > >the same file. > It's question for Wolfgang instead of me. Could you comment it? What is the better way? I don't know how likely it is that this code might ever be used by some other sources, so factoring out makes sense. If it's unlikely, then roll it into one. Best regards, Wolfgang Denk -- DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de It is undignified for a woman to play servant to a man who is not hers. -- Spock, "Amok Time", stardate 3372.7