From: Ralf Baechle <ralf@linux-mips.org>
To: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Cc: Atsushi Nemoto <anemo@mba.ocn.ne.jp>, linux-mips@linux-mips.org
Subject: Re: [PATCH][MIPS] add #include <linux/profile.h> to arch/mips/kernel/time.c
Date: Thu, 13 Sep 2007 12:29:23 +0100 [thread overview]
Message-ID: <20070913112923.GA31940@linux-mips.org> (raw)
In-Reply-To: <200709130413.l8D4DS73011392@po-mbox301.hop.2iij.net>
On Thu, Sep 13, 2007 at 01:13:28PM +0900, Yoichi Yuasa wrote:
> > linux/arch/mips/kernel/time.c:142: error: implicit declaration of function 'profile_tick'
> >
> > Proper fix would be including profile.h from time.c, but this is
> > irrelevant to i8259, so should be a separate patch.
>
> I found a patch for it in my patch queue.
>
> > Other parts looks good to me. Thanks.
>
> Add #include <linux/profile.h> to arch/mips/kernel/time.c
> It refer to CPU_PROFILING.
>
> arch/mips/kernel/time.c: In function 'local_timer_interrupt':
> arch/mips/kernel/time.c:142: error: implicit declaration of function 'profile_tick'
> arch/mips/kernel/time.c:142: error: 'CPU_PROFILING' undeclared (first use in this function)
> arch/mips/kernel/time.c:142: error: (Each undeclared identifier is reported only once
> arch/mips/kernel/time.c:142: error: for each function it appears in.)
>
> Signed-off-by: Yoichi Yuasa <yoichi_yuasa@tripeaks.co.jp>
Thanks, applied.
Ralf
next prev parent reply other threads:[~2007-09-13 11:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 14:23 [PATCH][MIPS] move i8259 functions to include/asm-mips/i8259.h Yoichi Yuasa
2007-09-12 15:33 ` Atsushi Nemoto
2007-09-13 2:04 ` Yoichi Yuasa
2007-09-13 2:29 ` Atsushi Nemoto
2007-09-13 4:13 ` [PATCH][MIPS] add #include <linux/profile.h> to arch/mips/kernel/time.c Yoichi Yuasa
2007-09-13 11:29 ` Ralf Baechle [this message]
2007-09-13 12:10 ` [PATCH][MIPS] move i8259 functions to include/asm-mips/i8259.h Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070913112923.GA31940@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=anemo@mba.ocn.ne.jp \
--cc=linux-mips@linux-mips.org \
--cc=yoichi_yuasa@tripeaks.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.